Skip to content

Conversation

@satwiksps
Copy link
Contributor

[BUG] Fix zero-distance instability in Hidalgo (#3068)

What does this implement/fix? Explain your changes.

This PR resolves a numerical instability in the Hidalgo segmenter that occurs when two or more rows in the input data are identical or extremely close. In such cases, the nearest-neighbor search returns r1 = 0 for some points, and the original implementation computed mu = r2 / r1. This produced infinite values for mu, which then propagated into downstream parameters (such as b1), eventually causing a crash in the Gibbs sampler (sample_d) due to invalid likelihood calculations.

To fix this, a small numerical epsilon (1e-12) is introduced when computing mu, ensuring that the denominator is never zero. This preserves normal behavior for valid datasets, while preventing the zero-division crash that triggered the issue. This approach follows @TonyBagnall's guidance from the issue discussion. A local regression test confirms that the real dataset from issue #3068 now runs without errors.

Does your contribution introduce a new dependency?

No new dependencies.

Any other comments?

PR checklist

For all contributions

  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

For new estimators and functions

  • I've added the estimator/function to the online API documentation.
  • (OPTIONAL) I've added myself as a maintainer at the top of relevant files and want to be contacted regarding its maintenance.

For developers with write access

  • (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

@aeon-actions-bot aeon-actions-bot bot added bug Something isn't working segmentation Segmentation package labels Nov 17, 2025
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ bug ].
I have added the following labels to this PR based on the changes made: [ segmentation ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Regenerate expected results for testing
  • Push an empty commit to re-run CI checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working segmentation Segmentation package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][Hidalgo] AssertionError: assert rmax > 0

1 participant