Enable core version publish check, as dry run #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables a previously commented-out version check for the core qtil package in the GitHub workflow and runs the publish command in dry-run mode. The changes activate the version comparison logic to determine whether publishing is needed based on differences between the published and local versions.
Key Changes:
- Uncommented and enabled the core qtil version check step
- Added dry-run flag to the publish command for testing purposes
- Added conditional execution to setup and publish steps based on version check results
| echo "Publishing pack 'qtil'." | ||
| codeql pack install "src" | ||
| codeql pack publish "src" | ||
| codeql pack publish --dry-run "src" |
There was a problem hiding this comment.
The --dry-run flag suggests this is for testing purposes. Consider adding a comment or workflow input parameter to control when dry-run mode should be used versus actual publishing.
Suggested change
| codeql pack publish --dry-run "src" | |
| if [ "${{ inputs.dry-run }}" == "true" ]; then | |
| codeql pack publish --dry-run "src" | |
| else | |
| codeql pack publish "src" | |
| fi |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.