Skip to content

Conversation

@samsrabin
Copy link
Collaborator

@samsrabin samsrabin commented Jun 12, 2025

  • Gets actual path to default config file to enable running from anywhere.
  • Adds an error check that would have helped in my troubleshooting.
  • Adds optional --config-file argument.
  • Adds netCDF file required for unit testing.

CTSM PR here: ESCOMP/CTSM#3251

@samsrabin
Copy link
Collaborator Author

samsrabin commented Jun 13, 2025

@glemieux I've added a netCDF file required by the functional unit testing, via git LFS, which seems new for the FATES repo. I wanted to check in with you on that—does it seem acceptable? This means that any tracked netCDF files will be handled by git LFS, but I left *.nc in the .gitignore file, so actually tracking a netCDF file will require someone to use the --force flag with git add.

@glemieux
Copy link
Collaborator

@glemieux I've added a netCDF file required by the functional unit testing, via git LFS, which seems new for the FATES repo. I wanted to check in with you on that—does it seem acceptable? This means that any tracked netCDF files will be handled by git LFS, but I left *.nc in the .gitignore file, so actually tracking a netCDF file will require someone to use the --force flag with git add.

I think that makes sense. I like keeping the .nc file in the .gitignore but allowing a way to force it for testing. Thanks for checking.

@samsrabin
Copy link
Collaborator Author

Thanks! Converting to draft while I work on a SystemTest for run_functional_tests.py.

@samsrabin samsrabin marked this pull request as draft June 13, 2025 17:58
@samsrabin
Copy link
Collaborator Author

Hmm. git lfs is giving me trouble. Reverted and testing some more.

@samsrabin samsrabin changed the title Unit test improvements to enable CTSM SystemTest Unit/functional test improvements to enable CTSM SystemTest Jun 13, 2025
@samsrabin samsrabin changed the title Unit/functional test improvements to enable CTSM SystemTest Unit/functional test improvements to enable CTSM SystemTests Jun 13, 2025
@samsrabin
Copy link
Collaborator Author

Closing to replace with NGEET#1426.

@samsrabin samsrabin closed this Jun 18, 2025
adrifoster pushed a commit that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants