Skip to content

Conversation

@gdams
Copy link
Member

@gdams gdams commented Oct 22, 2024

This will require some thorough testing but we should make this change. We'll also have to consider the upstream changes to jobs that trigger aqa-test runs by passing parameters

@llxia
Copy link
Contributor

llxia commented Oct 22, 2024

In addition to ensuring all upstream pipelines (i.e., Adoptium, Openj9, Semeru, etc) pass the correct parameters, this change requires regenerating or updating all test jobs and Grinders across all sites. Coordination between all sites is necessary.

Move this PR into draft until we have a plan with all necessary changes.

cc @smlambert for awareness

@llxia llxia marked this pull request as draft October 22, 2024 16:01
@smlambert
Copy link
Contributor

If we are going to proceed with this change, it will need to be communicated clearly to everyone downstream who is using AQAvit and be impacted, as they will all need to update their setups. I also would prefer to call it AQAVIT_REPO/BRANCH instead of ADOPTIUM_REPO/BRANCH. There needs to be an update of documentation in other several other repositories that will be required (and possibly tagging a bunch of presentations as outdated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants