Skip to content

INTL1207 - Add content-toggle block for A/B test campaign - #6451

Open
elindseth wants to merge 1 commit into
stagefrom
intl1207-content-toggle
Open

INTL1207 - Add content-toggle block for A/B test campaign#6451
elindseth wants to merge 1 commit into
stagefrom
intl1207-content-toggle

Conversation

@elindseth

@elindseth elindseth commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@aem-code-sync

aem-code-sync Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@github-actions

Copy link
Copy Markdown
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@jpratt2

jpratt2 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@elindseth Here is a code review from Claude:
No blockers.PR-6451-review.docx

@jpratt2

jpratt2 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Note: I don't expect you to act on all of the suggestions from Claude. There are no blockers, so I consider all of the other suggestions optional.

@elindseth

Copy link
Copy Markdown
Contributor Author

@elindseth When I use this URL in a mobile phone emulator in Chrome dev tools, I am noticing that the toggle defaults to "desktop" when I add the new intl1207.json manifest via the MEP button : Is this OK / expected?

@jpratt2 There is an expectation that it starts in desktop for this test campaign. That is how I've parsed the charter anyway. There is a config option to make it default to the second toggle option, but nothing that makes it detect the device. That might be the more logical behaviour, and a good enhancement if this test wins.

The block was initially written for Express vs CC so I didn't consider baking in any such mobile enhancements. Maybe I should have. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants