INTL1207 - Add content-toggle block for A/B test campaign - #6451
INTL1207 - Add content-toggle block for A/B test campaign#6451elindseth wants to merge 1 commit into
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
3e43ba8 to
82eda11
Compare
|
@elindseth Here is a code review from Claude: |
|
@elindseth https://main--da-cc--adobecom.aem.page/uk/products/premiere?milolibs=intl1207-content-toggle&mep=%2Fuk%2Fcc-shared%2Ffragments%2Froc%2Fmep%2Fproducts%2Fpremiere%2Froc-premiere.json--default---%2Fproducts%2Fpremiere.json--phone---%2Fcc-shared%2Ffragments%2Fpromos%2F2026%2Fglobal%2Ffirefly-crosslinking-banner.json--default---%2Fcc-shared%2Ffragments%2Fpromos%2F2026%2Fglobal%2Ffooter-de-kr%2Fseparate-de.json--default---%2Fcc-shared%2Ffragments%2Fpromos%2F2026%2Fglobal%2Ffooter-de-kr%2Fseparate-kr.json--default |
|
Note: I don't expect you to act on all of the suggestions from Claude. There are no blockers, so I consider all of the other suggestions optional. |
@jpratt2 There is an expectation that it starts in desktop for this test campaign. That is how I've parsed the charter anyway. There is a config option to make it default to the second toggle option, but nothing that makes it detect the device. That might be the more logical behaviour, and a good enhancement if this test wins. The block was initially written for Express vs CC so I didn't consider baking in any such mobile enhancements. Maybe I should have. :) |

This PR adds new functionality to the content-toggle block that has previously been tested.
New functionality:
Resolves: OPT-42221
Test URLs: