Skip to content

Add PPN dropdown nala tests for DA metadata builder - #115

Open
JackySun9 wants to merge 2 commits into
adobecom:stagefrom
JackySun9:nala/ppn-dropdown-tests
Open

Add PPN dropdown nala tests for DA metadata builder#115
JackySun9 wants to merge 2 commits into
adobecom:stagefrom
JackySun9:nala/ppn-dropdown-tests

Conversation

@JackySun9

Copy link
Copy Markdown
Collaborator

Summary

  • Migrate PPN dropdown tests from the centralized nala repo to da-bacom where the block code lives
  • Tests follow the existing nala/blocks/<block>/ pattern used by stats, tree-view, event-speakers, etc.
  • 14 test cases covering:
    • Functional (TC-001 to TC-005): dropdown values, selection, free text prevention, metadata population, library integration
    • Bug regression (TC-006 to TC-009): empty values, value reset on property switch, add-without-value prevention, complex flow
    • Non-functional (TC-010 to TC-011): DA UI integration, governance/circumvention prevention
    • Edge cases (TC-012 to TC-014): multiple pairs, removal, first-section error

Why move from nala?

Tests for da-bacom blocks should live alongside the code they test. This enables:

  • Tests run automatically on PRs that change the block
  • Developers see and maintain tests with their code
  • No cross-repo coordination needed

Test plan

  • Run PPN dropdown tests on DA Live (requires DA authentication)
  • Verify tests match the existing nala block test pattern

Made with Cursor

@codecov-commenter

codecov-commenter commented Feb 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (stage@352128d). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             stage     #115   +/-   ##
========================================
  Coverage         ?   91.14%           
========================================
  Files            ?       26           
  Lines            ?     4508           
  Branches         ?        0           
========================================
  Hits             ?     4109           
  Misses           ?      399           
  Partials         ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Migrate PPN dropdown tests from the nala repo to da-bacom where the
block code lives. Tests cover functional, bug regression, non-functional,
and edge cases for the primaryProductName dropdown in the DA UI metadata
builder.

Co-authored-by: Cursor <cursoragent@cursor.com>
@JackySun9
JackySun9 force-pushed the nala/ppn-dropdown-tests branch from 2ddcf0b to dd53f99 Compare March 26, 2026 02:46
@JackySun9
JackySun9 changed the base branch from main to stage March 26, 2026 02:47
@JackySun9
JackySun9 requested a review from Dli3 March 26, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants