Add PPN dropdown nala tests for DA metadata builder - #115
Open
JackySun9 wants to merge 2 commits into
Open
Conversation
JackySun9
requested review from
Brandon32,
JasonHowellSlavin and
jsandland
as code owners
February 24, 2026 20:30
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stage #115 +/- ##
========================================
Coverage ? 91.14%
========================================
Files ? 26
Lines ? 4508
Branches ? 0
========================================
Hits ? 4109
Misses ? 399
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Migrate PPN dropdown tests from the nala repo to da-bacom where the block code lives. Tests cover functional, bug regression, non-functional, and edge cases for the primaryProductName dropdown in the DA UI metadata builder. Co-authored-by: Cursor <cursoragent@cursor.com>
JackySun9
force-pushed
the
nala/ppn-dropdown-tests
branch
from
March 26, 2026 02:46
2ddcf0b to
dd53f99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nalarepo toda-bacomwhere the block code livesnala/blocks/<block>/pattern used by stats, tree-view, event-speakers, etc.Why move from nala?
Tests for da-bacom blocks should live alongside the code they test. This enables:
Test plan
Made with Cursor