Skip to content

fix: Added Banner/Padding/Horizontal/Compact to Layout collection#307

Merged
GarthDB merged 2 commits into
mainfrom
SDS-16501-bugfix-banner-horizontal-compact
Jun 8, 2026
Merged

fix: Added Banner/Padding/Horizontal/Compact to Layout collection#307
GarthDB merged 2 commits into
mainfrom
SDS-16501-bugfix-banner-horizontal-compact

Conversation

@NateBaldwinDesign

Copy link
Copy Markdown
Contributor

Description

Added Banner/Padding/Horizontal/Compact to Layout collection

Note: Banner/Padding/Horizontal needed renamed with "/Regular" in order to fit within tokens studio and Figma's hierarchical naming system

Motivation and context

This token was missing from Figma's S2 / Variables library due to it's omission from the Layout collection in Tokens studio.

Related issue

SDS-16501

Types of changes

Note: It is unclear to me at this time if the "horizontal/regular" name change will be a breaking change, since Tokens studio does not appear to use UUIDs or other IDs in their token data. Please advise

  • Patch (bug fixes, typos, mistakes; non-breaking change which fixes an issue)
  • Minor (add a new token, changing a value, deprecating a token; non-breaking change which adds functionality)
  • Major (deleting a token, changing token value type, renaming a token by deprecating the old one; fix or feature that would cause existing functionality to change)
  • Checklist:

  • I have signed the [Adobe Open Source CLA](https://opensource.adobe.com/cla.html).
  • I updated the token in all applicable sets. This applies if updating, adding, or deleting a token that has data across different sets (for example, if the value differs across color themes.)
  • Note: Banner/Padding/Horizontal needed renamed with "/Regular" in order to fit within tokens studio and Figma's hierarchical naming system
    @NateBaldwinDesign NateBaldwinDesign requested a review from a team as a code owner June 3, 2026 18:53
    @mrcjhicks

    Copy link
    Copy Markdown
    Collaborator

    TESTING spectrum2

    READING spectrum-design-data: /spectrum-design-data/packages/tokens/src/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-colors/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/

    TEST COMPLETE

    @mrcjhicks

    Copy link
    Copy Markdown
    Collaborator

    This change doesn't impact spectrum-design-data, only changes the public variable collection in figma.

    @GarthDB GarthDB merged commit b6e2e30 into main Jun 8, 2026
    4 checks passed
    @GarthDB GarthDB deleted the SDS-16501-bugfix-banner-horizontal-compact branch June 8, 2026 18:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants