feat(action-menu): S2 migration [CSS-1160] #4085
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| --- | ||
| "@spectrum-css/actionmenu": major | ||
| "@spectrum-css/actionbutton": minor | ||
| "@spectrum-css/menu": patch | ||
| "@spectrum-css/actiongroup": patch | ||
| --- | ||
|
|
||
| ### Action menu component (now with custom styles!) | ||
|
|
||
| Introduces `@spectrum-css/actionmenu`, a composition of `ActionButton`, `Popover`, and `Menu` to present action lists from a trigger. Now with custom styles! | ||
|
|
||
| - Adds wrapper classes: `spectrum-ActionMenu`, `spectrum-ActionMenu-trigger`, `spectrum-ActionMenu-popover`, and `spectrum-ActionMenu-menu`. | ||
| - Supports long press triggers and four placements (start/end, top/bottom) via the underlying popover API. | ||
| - Design reference: [Figma S2 token specs](https://www.figma.com/design/eoZHKJH9a3LJkHYCGt60Vb/S2-token-specs?node-id=20959-21513&node-type=frame&t=jbePQKK1yLdrHG2M-11). | ||
|
|
||
| #### Migration notes | ||
|
|
||
| - If you previously composed an action menu manually (action button + popover + menu), you can adopt the new wrapper classes without changing the underlying markup semantics. Ensure the trigger has `aria-haspopup="menu"` and manages `aria-expanded` according to your application logic. | ||
| - For spacing customizations previously done with ad‑hoc margins, switch to the new `--spectrum-actionmenu-button-to-menu-gap` custom property. | ||
|
|
||
| Example markup: | ||
|
|
||
| ```html | ||
| <div class="spectrum-ActionMenu"> | ||
| <button | ||
| class="spectrum-ActionMenu-trigger spectrum-ActionButton" | ||
| aria-haspopup="menu" | ||
| aria-expanded="false" | ||
| > | ||
| <!-- icon/label --> | ||
| </button> | ||
| <div class="spectrum-ActionMenu-popover spectrum-Popover"> | ||
| <ul class="spectrum-ActionMenu-menu spectrum-Menu"> | ||
| <!-- menu items --> | ||
| </ul> | ||
| </div> | ||
| <!-- popover positioning/visibility is owned by your implementation --> | ||
| <!-- use long-press behavior when appropriate to your UX --> | ||
| <!-- use Popover placement options: bottom-start, bottom-end, start-top, end-top --> | ||
| </div> | ||
| ``` | ||
|
|
||
| ### Menu refinements | ||
|
|
||
| Updates `@spectrum-css/menu` styles to align with latest Spectrum 2 design specifications and improve accessibility. | ||
|
|
||
| - Updated `.is-selectableMultiple .spectrum-Menu-itemCheckbox` to `.is-selectableMultiple:not(:has(.is-selectable)) .spectrum-Menu-itemCheckbox` to prevent clash with the `.is-selectable` placement. | ||
| - Non-breaking; no class or DOM changes required. | ||
|
|
||
| ### Action button refinements | ||
|
|
||
| - Selection styling now applies when components use ARIA pressed/expanded semantics, not just `.is-selected`. | ||
| - Implemented with `:where()` to keep selector specificity low and prevent downstream specificity battles. | ||
| - Non-breaking; no class changes required. | ||
|
|
||
| ### Action group refinements | ||
|
|
||
| Aligns selection behavior of grouped items with action button updates. | ||
|
|
||
| - Adds `:where([aria-pressed="true"], [aria-expanded="true"])` alongside `.is-selected` on items to cover more accessibility use-cases while keeping specificity low. | ||
| - Non-breaking; no class changes required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is for S2 and we've agreed to remove modifiers, I removed the mods on any lines I needed to update for this change anyway.