-
Notifications
You must be signed in to change notification settings - Fork 16
fix: url inspector channel filtering check for semrush dashboards #2940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vivesing
wants to merge
5
commits into
main
Choose a base branch
from
feat/channel-filter-sr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5aa7efa
fix: url inspector channel filtering check
vivesing ffb1f6f
Merge branch 'main' into feat/channel-filter-sr
vivesing 2ae53f6
add test
vivesing 4047e41
Merge branch 'main' into feat/channel-filter-sr
vivesing 5a7598c
address review comments
vivesing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /* | ||
| * Copyright 2026 Adobe. All rights reserved. | ||
| * This file is licensed to you under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. You may obtain a copy | ||
| * of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software distributed under | ||
| * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS | ||
| * OF ANY KIND, either express or implied. See the License for the specific language | ||
| * governing permissions and limitations under the License. | ||
| */ | ||
|
|
||
| import { expect } from 'chai'; | ||
| import { normalizeChannel } from '../../../src/support/elements/constants.js'; | ||
|
|
||
| describe('normalizeChannel', () => { | ||
| it('returns an empty string for null', () => { | ||
| expect(normalizeChannel(null)).to.equal(''); | ||
| }); | ||
|
|
||
| it('returns an empty string for undefined', () => { | ||
| expect(normalizeChannel(undefined)).to.equal(''); | ||
| }); | ||
|
|
||
| it('returns an empty string for an empty string', () => { | ||
| expect(normalizeChannel('')).to.equal(''); | ||
| }); | ||
|
|
||
| it('returns an empty string for a whitespace-only string', () => { | ||
| expect(normalizeChannel(' ')).to.equal(''); | ||
| }); | ||
|
|
||
| it('lowercases and preserves a snake_case value as spaces', () => { | ||
| expect(normalizeChannel('benchmark_competitors')).to.equal('benchmark competitors'); | ||
| }); | ||
|
|
||
| it('normalizes a Title Case, space-separated value to the same canonical form', () => { | ||
| expect(normalizeChannel('Benchmark Competitors')).to.equal('benchmark competitors'); | ||
| }); | ||
|
|
||
| it('normalizes a hyphenated value the same way as snake_case', () => { | ||
| expect(normalizeChannel('ai-generated')).to.equal('ai generated'); | ||
| }); | ||
|
|
||
| it('collapses repeated separators and trims surrounding whitespace', () => { | ||
| expect(normalizeChannel(' Benchmark__Competitors ')).to.equal('benchmark competitors'); | ||
| }); | ||
|
|
||
| it('leaves a single-word value unaffected apart from casing', () => { | ||
| expect(normalizeChannel('Owned')).to.equal('owned'); | ||
| }); | ||
|
|
||
| it('collapses repeated internal whitespace to match the snake_case form', () => { | ||
| expect(normalizeChannel('Benchmark Competitors')).to.equal('benchmark competitors'); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.