fix: v3 menus alternative approach #9345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
LFDanLu
reviewed
Dec 15, 2025
Member
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
looks good to me, running chromatic, will approve after that if it runs clean
devongovett
reviewed
Dec 15, 2025
LFDanLu
previously approved these changes
Dec 15, 2025
|
Build successful! 🎉 |
|
Build successful! 🎉 |
devongovett
approved these changes
Dec 16, 2025
dannify
approved these changes
Dec 16, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
* fix: v3 menus alternative approach * restrict to only submenu and remove extra export * remove extra export
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
alternative to #9343 that uses the old code so we don't introduce last minute changes to overlay positioning in our release
Positioning issues can be verified in storybook or new docs. In storybook it was easiest to see in the submenu stories with many items. In the docs, you need to scroll so that the bottom of the menu is as close to the bottom as possible without flipping.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: