docs: Homepage updates and fixes #9344
Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
snowystinger
left a comment
snowystinger
left a comment
There was a problem hiding this comment.
Unrelated to this PR, but general feedback I had while reviewing and didn't want to forget. I wish the component card background gradients in RAC and RSP were different.
nwidynski
left a comment
nwidynski
left a comment
There was a problem hiding this comment.
Idk if this is up for review already, but since @snowstinger left some remarks I thought I might as well give it a test session, haha.
| let labelRef = useRef<HTMLDivElement | null>(null); | ||
| let searchRef = useRef<HTMLDivElement | null>(null); | ||
|
|
||
| let openSearchMenu = async () => { |
There was a problem hiding this comment.
The search menu transition causes frames to be dropped on my device when first opened. Idk exactly what causes it and can't record with the native screen recorder because that's also low fps and won't show 😅
There was a problem hiding this comment.
I tried delaying the pre-fetching until after the view transition finishes and that seems to have helped a bit.
| default: 0, | ||
| '@media (width >= 1440px)': space(38) | ||
| }, | ||
| zIndex: 2, |
| }); | ||
| }; | ||
|
|
||
| let closeSearchMenu = () => { |
There was a problem hiding this comment.
Transition timing should probably be tweaked to avoid these ghosting issues on fade out.
Screen.Recording.2025-12-15.at.6.30.17.PM.mov
|
Build successful! 🎉 |
snowystinger
left a comment
snowystinger
left a comment
There was a problem hiding this comment.
favicon for react aria needs updating?
| let pageUrl = typeof window !== 'undefined' && url ? new URL(url, window.location.origin).href : url ?? ''; | ||
| let fullMdUrl = typeof window !== 'undefined' && mdUrl ? new URL(mdUrl, window.location.origin).href : mdUrl; | ||
| let library = url ? getLibraryLabel(getLibraryFromUrl(url)) : ''; | ||
| let library = url ? getLibraryLabel(getLibraryFromUrl(name)) : ''; |
There was a problem hiding this comment.
rename to getLibraryFromName now?
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
No description provided.