Skip to content

Conversation

snowystinger
Copy link
Member

Closes

A few remaining items that I realised I'd forgotten

Adds a background colour to hovered cells.
Adds new docs example
Remove unused onCancel prop

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:


### EditableCell

<PropTable component={docs.exports.EditableCell} links={docs.links} showDescription />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do i debug the PropTable.tsx component? I can't tell why placement is being added to an Overlay group in the table

Also, noticed that I cannot see the bottom of the TOC unless I scroll to the bottom of the page

styles: style({
// TODO: really need access to display here instead, but not possible right now
// will be addressable with displayOuter
// Could use `hidden` attribute instead of css, but I don't have access to much of this state at the moment
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still need to solve this issue

@rspbot
Copy link

rspbot commented Oct 9, 2025

@rspbot
Copy link

rspbot commented Oct 9, 2025

## API Changes

@react-spectrum/s2

/@react-spectrum/s2:EditableCell

 EditableCell {
   align?: 'start' | 'center' | 'end' = 'start'
   children: ReactNode
   className?: ClassNameOrFunction<CellRenderProps> = 'react-aria-Cell'
   colSpan?: number
   id?: Key
   isSaving?: boolean
-  onCancel: () => void
   onSubmit: () => void
   renderEditing: () => ReactNode
   showDivider?: boolean
   style?: StyleOrFunction<CellRenderProps>
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants