Skip to content

docs(s2): close CardPreview with matching tag in Card anatomy - #10853

Merged
devongovett merged 1 commit into
adobe:mainfrom
mangeshraut712:cursor/fix-card-preview-close-tag-10825
Oct 26, 2026
Merged

devongovett merged 1 commit into
adobe:mainfrom
mangeshraut712:cursor/fix-card-preview-close-tag-10825

Conversation

@mangeshraut712

Copy link
Copy Markdown
Contributor

Closes #10825

The AssetCard, UserCard, and ProductCard anatomy examples in packages/dev/s2-docs/pages/s2/Card.mdx opened <CardPreview> and closed with </CardView>, so copying them produced invalid JSX. The other examples on the page already use </CardPreview>.

I did not find a checked-in references/components/Card.md skill mirror with the same mismatch; that path appears generated from this page.

Checklist

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (docs-only).
  • Filled out test instructions.
  • Updated documentation.
  • I understand every change in this PR and can explain why it's there.

Test Instructions

Open packages/dev/s2-docs/pages/s2/Card.mdx and confirm the three anatomy examples close CardPreview with </CardPreview>.

The AssetCard, UserCard, and ProductCard anatomy examples opened
CardPreview but closed with CardView, so copying them produced invalid JSX.
@github-actions github-actions Bot added the S2 label Oct 25, 2026
@mangeshraut712

Copy link
Copy Markdown
Contributor Author

Friendly ping — CI is green on this docs-only fix for the CardPreview close tags in the Card anatomy examples (closes #10825). Happy to adjust if anything looks off.

@mangeshraut712

Copy link
Copy Markdown
Contributor Author

Quick bump — this is a one-line close-tag fix in the S2 Card anatomy docs (CardPreview opened, CardView closed), so the copy-paste examples are valid again. CI is green on the tip whenever someone has a minute to take a look.

@mangeshraut712

Copy link
Copy Markdown
Contributor Author

Still green — ready whenever you are.

@mangeshraut712

Copy link
Copy Markdown
Contributor Author

CI is green on this. Docs-only: closes CardPreview with the matching tag in the S2 Card anatomy examples so the copy-paste markup is valid. If it looks good, could you please review and merge when you get a chance? Thanks.

@reidbarber

Copy link
Copy Markdown
Member

There is no need for the repetitive comments. It will not help your changes get reviewed sooner, and it worsens the experience for contributors and maintainers alike.

@devongovett
devongovett added this pull request to the merge queue Oct 26, 2026
Merged via the queue into adobe:main with commit 06891de Oct 26, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S2 docs: Card anatomy examples close <CardPreview> with </CardView>

3 participants