feat: Update AttachmentList to support Illustrations for preview and update invalid styling for preview only - #10452
Conversation
…llustration and text
…n, get rid of reliance on horizontal card
|
Build successful! 🎉 |
snowystinger
left a comment
There was a problem hiding this comment.
fully delete the HorizontalCard file?
couple quick things
|
Build successful! 🎉 |
Agent Skills ChangesModified (2)
InstallReact Spectrum S2: React Aria: |
snowystinger
left a comment
There was a problem hiding this comment.
Looks pretty good. I assume the invalid to the right of the text is by design? It'd be nice if it replaced the thumb/icon just like the square ones, it'd take up less space and wouldn't shift things if it became invalid then valid or vice versa
|
@snowystinger I actually can't find the design for the invalid state when there is text in the attachment (or the designs for the attachment at all haha). The replacing thumb/icon with the error icon was made up by me btw haha, but if ppl like it I think we could roll with that across the board. One thing to keep in mind though is that Coworker has a "valid" state too to signify that validation has been carried out which occupies a similar position and I can see an argument of not replacing the thumbnail in that case |

From testing + local testing. Updates AttachmentList to use Illustrations instead of Icons for previews, updates invalid styling for preview only attachments (opacity + adds invalid icon to center of the attachment), and removes reliance on HorizontalCard since that isn't meant have the same styling (S2 vs AI styling)
✅ Pull Request Checklist:
📝 Test Instructions:
Test the "Mixed attachments" story across invalid/in progress upload/etc. Also test isInvalid + only image preview via the "AI attachments" story.
🧢 Your Project:
RSP