feat: Add missing hold affordance icon for longPress S2 MenuTriggers - #10066
Conversation
|
Build successful! 🎉 |
| */ | ||
| isQuiet?: boolean; | ||
| /** @private */ | ||
| holdAffordance?: boolean; |
There was a problem hiding this comment.
just add to the context interface?
There was a problem hiding this comment.
oh good point, I guess I could use the same context in the Chromatic instead of using the prop directly too
| } | ||
| }; | ||
|
|
||
| export const HoldAffordance: Story = { |
There was a problem hiding this comment.
maybe we make it look a bit more like real ones?
Here's how photoshop uses something similar
|
@snowystinger docs actually already exist for this under https://d1pzu54gtk2aed.cloudfront.net/pr/20baef5c94eb4c797683a21575ec75d1b33e330c/ haha, definitely easy to miss. I didn't realize the same thing until I wrote some new docs and went through a whole debugging session ugh I'll put the above in the test instructions too |
|
Build successful! 🎉 |
| import {ImageContext} from './Image'; // chevron right removed?? | ||
| import InfoCircleIcon from '../s2wf-icons/S2_Icon_InfoCircle_20_N.svg'; |
There was a problem hiding this comment.
misplaced comment? Or should this be removed?
There was a problem hiding this comment.
ugh, must of been the formatter or auto import moving things around, thanks for the catch
|
Build successful! 🎉 |
5 participants
Closes #10029
Adds the hold affordance icon to "longPress" MenuTriggers in S2. Supports ActionButton and ToggleButton triggers
✅ Pull Request Checklist:
📝 Test Instructions:
Test the new story and see chromatic.
Also test the pre-existing docs and make sure the affordance icon and behavior works as expected.
🧢 Your Project:
RSP