Gauge #672
Open
Gauge #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found things we need to ask questions about adding case for gauge on chartSpecBuilder.ts Began adding Signals Messed with the signals Progress on Mark Working on Mark Util Marks Util Progress Marks Util Progress Mark Updates Adding Needle Rule Mark. Fixed paranthesis Got gauge to render Removed some comments Stinking # symbols WIP: gauge work Fixing the color problems. Added data-driven basics, color scheme corrections, and flexible props Fixed the filler arc to have the one straight edge Remove `track` from gaugeSpec Touched up currVal to be dynamic making the minimalistic skeleton for the gauge Simpler implementation Cleaned up basic Gauge Deleting a comment
…son/react-spectrum-charts into simple-implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates a Gauge chart component type and adds a simple example to the storybook.
Related Issue
(Need to create an issue)
Motivation and Context
The gauge chart helps visualize a metric of data as a fraction towards a goal point (which is represented by a full gauge). It shows progress towards a target.
How Has This Been Tested?
Tests using the jest framework have been added to cover all functional react and vega files created in support of the Gauge component.
Screenshot:
Types of changes
Checklist: