Skip to content

FORMS-21002: Programmatic label does not convey purpose of control @sunnym @vavarshn #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stefan-dragomir wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

FORMS-21002: Programmatic label does not convey purpose of control @sunnym @vavarshn #1745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
145db5d
FORMS-21002: Programmatic label does not convey purpose of control @s…
Oct 30, 2025
dfc4be5
FORMS-21002: Translation via JS instead of HTM
Nov 21, 2025
44f8916
FORMS-21002: Adding test cases for aria-label
Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...t/jcr_root/apps/core/fd/components/form/review/v1/review/clientlibs/site/js/reviewview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,6 @@
if(value){
value.setAttribute('aria-labelledby', id);
}
if(editButton && editButton.getAttribute(Review.DATA_ATTRIBUTE_VISIBLE) === 'true'){
editButton.setAttribute('aria-describedby', id);
}
}

static isRepeatable(item) {
Expand Down Expand Up @@ -308,7 +305,8 @@
const editButton = cloneNode.querySelector(Review.selectors.editButton);
if (editButton) {
editButton.setAttribute(Review.selectors.fieldId, item.id);
editButton.setAttribute('aria-label', item?.label?.value);
const currentItemLabel = item?.label?.value;
editButton.setAttribute('aria-label', Granite.I18n.get('Edit') + (currentItemLabel ? " " + currentItemLabel : ""));
if (item.enabled === false) {
editButton.setAttribute('disabled', true);
}
Expand Down
10 changes: 8 additions & 2 deletions ui.tests/test-module/specs/review/review.repeatability.runtime.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,10 @@ describe("Form with Review component with repeatablity", () => {
cy.get(`.${bemBlock}__container .${bemBlock}__panel`).eq(0).within(() => {
cy.get(`.${bemBlock}__label-container`).should('exist');
cy.get(`.${bemBlock}__label`).contains('Personal Information');
cy.get(`.${bemBlock}__edit-button`).should('have.attr', 'data-cmp-visible', 'true');
cy.get(`.${bemBlock}__edit-button`)
.should('have.attr', 'data-cmp-visible', 'true')
.should('have.attr', 'aria-label')
.and('contain', 'Personal Information');

cy.get(`.${bemBlock}__content`).should('exist').within(() => {
cy.get(`.${bemBlock}__field`).eq(0).within(() => {
Expand Down Expand Up @@ -122,7 +125,10 @@ describe("Form with Review component with repeatablity", () => {
cy.get(`.${bemBlock}__content`).should('exist').within(() => {
cy.get(`.${bemBlock}__label-container`).should('exist');
cy.get(`.${bemBlock}__label`).contains('Address');
cy.get(`.${bemBlock}__edit-button`).should('have.attr', 'data-cmp-visible', 'true');
cy.get(`.${bemBlock}__edit-button`)
.should('have.attr', 'data-cmp-visible', 'true')
.should('have.attr', 'aria-label')
.and('contain', 'Address');

cy.get(`.${bemBlock}__content`).should('exist').within(() => {
cy.get(`.${bemBlock}__field`).eq(0).within(() => {
Expand Down
35 changes: 28 additions & 7 deletions ui.tests/test-module/specs/review/review.runtime.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,19 @@ describe("Form with Review component", () => {
cy.get(`.${bemBlock}__field`).eq(0).within(() => {
cy.get(`.${bemBlock}__label`).contains('First name');
cy.get(`.${bemBlock}__value`).contains('john');
cy.get(`.${bemBlock}__edit-button`).should('have.attr', 'data-cmp-visible', 'true');
cy.get(`.${bemBlock}__edit-button`)
.should('have.attr', 'data-cmp-visible', 'true')
.should('have.attr', 'aria-label')
.and('contain', 'First name');
});

cy.get(`.${bemBlock}__field`).eq(1).within(() => {
cy.get(`.${bemBlock}__label`).contains('Last name');
cy.get(`.${bemBlock}__value`).contains('deo');
cy.get(`.${bemBlock}__edit-button`).should('have.attr', 'data-cmp-visible', 'true');
cy.get(`.${bemBlock}__edit-button`)
.should('have.attr', 'data-cmp-visible', 'true')
.should('have.attr', 'aria-label')
.and('contain', 'Last name');
});

cy.get(`.${bemBlock}__field`).eq(2).within(() => {
Expand All @@ -85,31 +91,46 @@ describe("Form with Review component", () => {
cy.get(`.${bemBlock}__field`).eq(3).within(() => {
cy.get(`.${bemBlock}__label`).contains('Email Address');
cy.get(`.${bemBlock}__value`).contains('[email protected]');
cy.get(`.${bemBlock}__edit-button`).should('have.attr', 'data-cmp-visible', 'true');
cy.get(`.${bemBlock}__edit-button`)
.should('have.attr', 'data-cmp-visible', 'true')
.should('have.attr', 'aria-label')
.and('contain', 'Email Address');
});

cy.get(`.${bemBlock}__field`).eq(4).within(() => {
cy.get(`.${bemBlock}__label`).contains('Mobile Number');
cy.get(`.${bemBlock}__value`).contains('+91987654321');
cy.get(`.${bemBlock}__edit-button`).should('have.attr', 'data-cmp-visible', 'true');
cy.get(`.${bemBlock}__edit-button`)
.should('have.attr', 'data-cmp-visible', 'true')
.should('have.attr', 'aria-label')
.and('contain', 'Mobile Number');
});

cy.get(`.${bemBlock}__field`).eq(5).within(() => {
cy.get(`.${bemBlock}__label`).contains('DOB');
cy.get(`.${bemBlock}__value`).contains('2020-10-10');
cy.get(`.${bemBlock}__edit-button`).should('have.attr', 'data-cmp-visible', 'true');
cy.get(`.${bemBlock}__edit-button`)
.should('have.attr', 'data-cmp-visible', 'true')
.should('have.attr', 'aria-label')
.and('contain', 'DOB');
});

cy.get(`.${bemBlock}__field`).eq(6).within(() => {
cy.get(`.${bemBlock}__label`).contains('Gender');
cy.get(`.${bemBlock}__value`).contains('Male');
cy.get(`.${bemBlock}__edit-button`).should('have.attr', 'data-cmp-visible', 'true');
cy.get(`.${bemBlock}__edit-button`)
.should('have.attr', 'data-cmp-visible', 'true')
.should('have.attr', 'aria-label')
.and('contain', 'Gender');
});

cy.get(`.${bemBlock}__field`).eq(7).within(() => {
cy.get(`.${bemBlock}__label`).contains('Interest');
cy.get(`.${bemBlock}__value`).contains('Music , Football');
cy.get(`.${bemBlock}__edit-button`).should('have.attr', 'data-cmp-visible', 'true');
cy.get(`.${bemBlock}__edit-button`)
.should('have.attr', 'data-cmp-visible', 'true')
.should('have.attr', 'aria-label')
.and('contain', 'Interest');
});
});
});
Expand Down
Loading