Issue #2 - too big images in small galleries#3
Open
SaySaeqo wants to merge 1 commit intoademonte:developfrom
Open
Issue #2 - too big images in small galleries#3SaySaeqo wants to merge 1 commit intoademonte:developfrom
SaySaeqo wants to merge 1 commit intoademonte:developfrom
Conversation
When the amount of images are so small that they cannot even fill a single line in gallery div, then they are scaled up to the width of container anyway. This produces unwanted behavior that creates big images (e.g. on entire screen) when we don't know how many images will be in the gallery beforehand. See issue ademonte#2 in main fork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the number of images is so small that they cannot even fill a single line in the gallery div, then they are scaled up to the width of the container anyway. This produces unwanted behavior that creates big images (e.g. on the entire screen) when we don't know how many images will be in the gallery beforehand.
See issue #2 for details on how to reproduce this issue.