-
Notifications
You must be signed in to change notification settings - Fork 250
New: Add GitHub Actions workflow to deploy v5 vanilla course to GitHub Pages (fix #3479) #3733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Ready for review. |
|
|
Deploy to the external repository, please. We should definitely not add a build folder to this repo. This repo is the expected destination: https://github.com/adaptlearning/adaptlearning.github.io The token |
|
Added the |
Fix #3479
New
Update
lts/*in test.yml❓Questions
lts/*or18?a. Noting that https://github.com/adaptlearning doesn't actually have a README.md doc. First time visitors may not realize that they need to visit the adapt_framework repo to get an overview. Separate issue to consider...
Technical explanations
How It Works
How It Works
npm ci→grunt build→ deploys tomasterbranch ofadaptlearning/adaptlearning.github.io repoin thev5demodirectory.Deployment Options Considered
Deployment Options Considered
peaceiris/actions-gh-pages@v4 (chosen):
actions/deploy-pages (official GitHub alternative):
Key Differences
Deployment Method:
Official Status:
Why We Chose peaceiris/actions-gh-pages@v4
For our specific use case (release-triggered Adapt course deployments with Grunt builds):
Both actions are valid and actively maintained. We chose peaceiris for simplicity, not because it's superior to the official action.