Skip to content

Conversation

@joe-replin
Copy link
Contributor

@joe-replin joe-replin commented Oct 28, 2025

Fix

New

  • Added visual "Optional" label below progress indicators when isOptional is true.
  • Added "Optional." prefix to aria-label for screen reader announcements
  • Implemented conditional wrapper rendering when label exists.

Testing

  1. Set "_isOptional": true on page content (manually or via diagnostic extension)
  2. Navigate to menu and verify:
  3. Progress indicator shows "Optional" label below the progress bar
  4. Empty progress bar displays correctly (0% instead of appearing full due to NaN)
  5. Navigate within the optional page and check the navigation bar progress indicator
  6. Test with screen reader - verify it announces "Optional" before progress information
  7. Test non-optional content - verify no extra wrapper elements or labels appear
  8. Inspect DOM - confirm pagelevelprogress__indicator-group only exists when content is optional

@cahirodoherty-learningpool cahirodoherty-learningpool moved this from New to Needs Reviewing in adapt_framework: The TODO Board Oct 30, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Needs Reviewing

Development

Successfully merging this pull request may close these issues.

Completion calculations can return NaN when page content is optional

4 participants