-
Notifications
You must be signed in to change notification settings - Fork 1.4k
add studiolab_picoexpander #10737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add studiolab_picoexpander #10737
Conversation
…changes. Lines starting
dhalbert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this looks fine overall. I've made some naming change suggestions.
| // | ||
| // SPDX-License-Identifier: MIT | ||
|
|
||
| #define MICROPY_HW_BOARD_NAME "Pico Expander" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add your manufacturer name here, like "Studiolab Pico Expander" or however you capitalize and space it ("Studio Lab", "studiolab", etc.)
|
Hi @dhalbert, |
|
Hi Dan, |
|
The doc build error you are seeing was due to another PR -- we'll fix that! It's unrelated to your PR at all. |
dhalbert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for doing my somewhat pedantic request about the pin order.
We'll ignore the docs build error for now.
|
Next step is to add the board to circuitpython.org: https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website |
Hi Dan, amazing to see it merged :D |
Hi all,
We made an expander board for the Pico 2W, The Pico 2W is soldered on the board, and it has some peripherals permanently connected to the board so it made sense to make a custom board file for it.
It is part of a bigger project to learn the Industrial Design students at the Technical University of Delft to program, more info here: https://id-studiolab.github.io/Connected-Interaction-Kit/test/components/
I built the board, copied the UF2 file, tested the functionality, and all seems good!
Since our previous board utilized the ItsyBitsy M4, we aim to maintain backward compatibility with the D pins. Therefore, we have ensured that students can use both D as well as GP syntax, for example: D5 as well as GP5.
Let me know if anything is unclear.