fix: time all URL parsers on the same inputs - #14
Open
lemire wants to merge 1 commit into
Open
Conversation
Stop breaking on the first parse error so goada, net/url, and whatwg-url are measured on the full top-100k dataset. Skip empty lines, keep parse results alive, and update README numbers from a re-run on Apple M4 Max.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The top-100k URL benchmarks were not comparable. Each
BenchmarkTop100*functionbreak'd on the first parse error, and the three libraries reject different inputs:So goada/whatwg-url were timed on 5,063 URLs while
net/urlwas timed on 7,828 — and none of them ran the full dataset. The README then dividedns/opby ~100k, which made every library look ~20× faster than it was.Changes
top100.txt(6 lines; not URLs)Remeasured numbers
Median of 7 runs (
-benchtime=3s -count=7) on Apple M4 Max, 100,025 URLs:net/urlReproduce with: