Sea Turtles-Jenny C#79
Conversation
tgoslee
left a comment
tgoslee
left a comment
There was a problem hiding this comment.
Great job Jenny! Your code was functional and I was able to do all of the required tasks in your weather app! I left some comments and shared some resources. Please let me know if you have any questions.
| <h1>Weather Report</h1> | ||
| </header> | ||
| <main> | ||
| <div class="grid-display"> |
There was a problem hiding this comment.
Most of your code in HTML is semantic. I think in this particular place you could've used something else besides a div. Here is a document you can use to walk through when to use particular tags:
There was a problem hiding this comment.
Thank you so much Trenisha.
| <footer> | ||
| </footer> |
There was a problem hiding this comment.
you don't need the footer tag if you do not have a footer
| <footer> | ||
| </footer> |
There was a problem hiding this comment.
you don't need the footer tag if you do not have a footer
| @@ -0,0 +1,139 @@ | |||
| 'use strict'; | |||
|
|
|||
| const state = { | |||
| @@ -0,0 +1,139 @@ | |||
| 'use strict'; | |||
|
|
|||
| const state = { | |||
| const increaseTemp = () => { | ||
| state.temperature += 1; | ||
| updateTempLabel(); | ||
| console.log('increase temp'); | ||
| }; | ||
|
|
||
| const decreaseTemp = () => { | ||
| state.temperature -= 1; | ||
| updateTempLabel(); | ||
| console.log('decrease temp'); | ||
| }; |
There was a problem hiding this comment.
functions look good but remove your console logs
|
|
||
| document.addEventListener('DOMContentLoaded', registerEventHandlers); | ||
|
|
||
| const getLatAndLong = () => { |
There was a problem hiding this comment.
small note. I would move this function and the function below this before you register the event handlers. Just to make the code more readable.
There was a problem hiding this comment.
ok, got it. I thought line 103 was only for all the events so I put it before the API calls. I see now that I put it at the end of index. Thank you
|
|
||
| document.addEventListener('DOMContentLoaded', registerEventHandlers); | ||
|
|
||
| const getLatAndLong = () => { |
There was a problem hiding this comment.
small note. I would move this function and the function below this before you register the event handlers. Just to make the code more readable.
|
|
||
|
|
There was a problem hiding this comment.
you can remove this white space and any other place that has extra white space to make your code more readable
|
|
||
|
|
There was a problem hiding this comment.
you can remove this white space and any other place that has extra white space to make your code more readable
2 participants
No description provided.