c17 Sharks - Xiomara Rodriguez

[xiomaraR]

still making some changes, but it's pretty much done!

[spitsfire]

Good job, Xiomara! A couple things to consider:

• Remember to remove any commented out code you aren't using for a final submission
• How can we dry up a few of the functions that are a long list of if statements and re-assigning state variables?

Something we could do is fatten up state with all of these values, like the emojis and font colors in aterTextColor that correlate to the sky or the temperature. For example:

const state = {
  stats: [
    { upperBound: 49, color: "teal", ground: "🌲🌲⛄️🌲⛄️🍂🌲🍁🌲🌲⛄️🍂🌲"},
    { upperBound: 60, color: "yellow", ground: "🌾🌾_🍃_🪨__🛤_🌾🌾🌾_🍃"}
  ]
}

Now we can iterate through our hard coded values that correlate to the right temp or sky by referencing a key just once. That's really all I saw that could be dried up! Nicely done!

[spitsfire]

Suggested change

	<!-- <section id="sky">
	<canvas id="icon" width="128" height="128"></canvas>
	</section> -->

[spitsfire]

Suggested change

<!-- <div id="skyChoice"></div> -->

[spitsfire]

Suggested change

	<!-- city text display -->
	<!-- <section id="citySection">
	<span id="cityDisplay">New York City</span>
	<button id="currentTempButton">Get Realtime Temperature</button>
	</section> -->

[spitsfire]

Suggested change

<!-- <script src="skycons.js"></script> -->

[spitsfire]

don't forget to get rid of code you aren't using:

Suggested change

	// change the sky
	// const setIcon = (icons, iconID) => {
	// const skycons = new Skycons({ color: '#2b2d42' });
	// const currentIcon = icons.replace(/-/g, '_').toUpperCase();
	// skycons.play();
	// return skycons.set(iconID, skycons[currentIcon]);
	// };

[spitsfire]

Suggested change

	// let skyContent = document.getElementById('body').style.background
	// const skyContent = document.getElementById('skyChoice');
	// let skyScape = '';

[spitsfire]

hmm should this be inside registerEventHandler? This will make sure that the DOM has loaded completely before any js is executed. Sometimes a js file can load faster than the HTML itself and cause errors.

[spitsfire]

Suggested change

// selectSkies.addEventListener('change', changeSky);

[spitsfire]

same as above. This might be better placed inside registerEventHandler

[spitsfire]

Suggested change

	// const setIcons = () => {
	// icons.set('clear-day', Skycons.CLEAR_DAY);
	// icons.set('rain', Skycons.RAIN);
	// icons.set('snow', Skycons.SNOW);
	// icons.set('wind', Skycons.WIND);
	// icons.play();
	// };