Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Docker build workflow and several Dockerfiles to streamline image building and maintenance. The main changes include removing certain build contexts from the workflow, updating base image versions for consistency, and adding the
bcutility to various Docker images.Workflow and build context updates:
ubuntu2404_cuda_oneapi,ubuntu2404_rocm_oneapi,alma9_rocm_oneapi,alma9_cuda_oneapi) from the.github/workflows/build-images.ymlworkflow to simplify the build matrix. [1] [2]gitlab-registry.cern.chin the workflow, focusing on GitHub Container Registry.Dockerfile improvements:
ghcr.io/acts-project/ubuntu2404:82in all relevant Dockerfiles (ubuntu2404_cuda,ubuntu2404_cuda_oneapi,ubuntu2404_rocm_oneapi,ubuntu2404_oneapi) for consistency and to use the latest dependencies. [1] [2] [3] [4]bcutility to the package installs in several Dockerfiles (ubuntu2404,ubuntu2404_clang19,ubuntu2404_gnn) to support scripts or applications that require it. [1] [2] [3]Maintenance and build logic:
ubuntu2404_tensorrtcontext in the conditional step.