feat: Python bindings for SimHit/SimHitContainer + UprootReader#5330
Open
benjaminhuth wants to merge 13 commits intoacts-project:mainfrom
Open
feat: Python bindings for SimHit/SimHitContainer + UprootReader#5330benjaminhuth wants to merge 13 commits intoacts-project:mainfrom
benjaminhuth wants to merge 13 commits intoacts-project:mainfrom
Conversation
… reader - Bind SimHit and SimHitContainer (with WhiteBoard registration) in Generators.cpp - Add setter methods to SimParticle binding for construction from Python - Add PyIReader trampoline so Python classes can subclass IReader - Update IReader binding to inherit from SequenceElement (fixes cast at runtime) - Implement UprootReader: single Python-only reader for particles + sim hits via uproot, usable without the ROOT plugin (for PyPI distribution) - Add test that simulates with Fatras + ROOT writers, reads back with UprootReader Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…hs in UprootReader
- Convert process/pdg/charge/mass/particleId SimParticle bindings from
def_property_readonly + def("setXxx") to def_property (read-write)
- Hardcode particle/hit tree names in UprootReader ("particles", "hits")
- Make particleFilePath and simHitFilePath optional (default None);
each handle is only initialized when its file is supplied
- Add particles-only and hits-only test variants
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…les-hits-python-uproot-reader
Contributor
andiwand
previously approved these changes
Apr 13, 2026
Contributor
andiwand
left a comment
andiwand
left a comment
There was a problem hiding this comment.
LGTM - just left a few minor comments
|
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
andiwand
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
uproot-based particle and simhit readers for the PyPI distribution of acts.--- END COMMIT MESSAGE ---
Any further description goes here, @-mentions are ok here!
feat,fix,refactor,docs,choreandbuildtypes.