feat: part 2 of migration to GBTSv3#5328
Merged
kodiakhq[bot] merged 19 commits intoacts-project:mainfrom Apr 11, 2026
Merged
Conversation
andiwand
reviewed
Apr 9, 2026
jpreston-cern
force-pushed
the
GBTSv3_ACTS_refactor
branch
from
65cf457 to
847f3ce
Compare
andiwand
reviewed
Apr 11, 2026
andiwand
reviewed
Apr 11, 2026
andiwand
reviewed
Apr 11, 2026
andiwand
reviewed
Apr 11, 2026
andiwand
reviewed
Apr 11, 2026
andiwand
reviewed
Apr 11, 2026
andiwand
reviewed
Apr 11, 2026
andiwand
reviewed
Apr 11, 2026
github-actions
bot
added
Component - Examples
andiwand
approved these changes
Apr 11, 2026
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second part of the migration of GBBTSv3 to ACTS which focusses on efficiency improvements, specifically in the barrel.
Features include:
addition of extra check in barrel edge connections via
validateTripletwhich checks for Pt and d0 consistancyupdates to clone removal and addition of seed splitting which for long seeds (and low eta) splits them in two to help the CKF find the true track
more leniency in the tau ratio for edge connections that miss a layer (as we expect more detector effects for these edge connections)
General transition to ACTS units where applicable to make it easier for the user to understand config veriables
--- END COMMIT MESSAGE ---
@timadye @andiwand
NOTE: magic numbers are still present in this PR that are to do with geometry, a future PR will be designated to pull those out (and renamed to be more readable)
NOTE: this gives a slight difference in seeds compared to the the athena version due to differing levels of floating point precision