feat: replace boost::hash_combine with murmur3-mixed hashCombine#5325
Merged
kodiakhq[bot] merged 10 commits intoacts-project:mainfrom Apr 13, 2026
Merged
feat: replace boost::hash_combine with murmur3-mixed hashCombine#5325kodiakhq[bot] merged 10 commits intoacts-project:mainfrom
kodiakhq[bot] merged 10 commits intoacts-project:mainfrom
Conversation
github-actions
bot
added
Component - Core
Member
Author
|
See #5321 |
Add Acts::hashCombine utility that applies the murmur3 fmix64 finalizer before boost::hash_combine, fixing poor hash distribution for small or sequential integer inputs (where std::hash is typically the identity). - New Core/include/Acts/Utilities/HashCombine.hpp with hashMix and hashCombine - Replace all 5 boost::hash_combine call sites (Barcode, RandomNumbers, TrackFindingAlgorithm, ClusterizationTests) - Add unit tests with collision rate checks for up to 2.5M inputs
paulgessinger
force-pushed
the
fix/boost-combine-dist
branch
from
b56e8ae to
cda4425
Compare
andiwand
reviewed
Apr 9, 2026
Contributor
andiwand
left a comment
andiwand
left a comment
There was a problem hiding this comment.
thanks for tackling this to swiftly!
andiwand
reviewed
Apr 9, 2026
Contributor
Corentin-Allaire
left a comment
Corentin-Allaire
left a comment
There was a problem hiding this comment.
Looks good to me ! Thanks a lot for the quick fix.
Contributor
github-actions
bot
added
Infrastructure
andiwand
previously approved these changes
Apr 11, 2026
paulgessinger
force-pushed
the
fix/boost-combine-dist
branch
from
4e9f6cb to
91aab98
Compare
andiwand
approved these changes
Apr 13, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Acts::hashCombine utility that applies the murmur3 fmix64 finalizer before boost::hash_combine, fixing poor hash distribution for small or sequential integer inputs (where std::hash is typically the identity).