fix: bug fixes for GraphBasedSeedingConfig and layerNumbering function in examples #5323
Merged
andiwand merged 5 commits intoacts-project:mainfrom Apr 12, 2026
Merged
Conversation
and layerNumbering`GraphBasedSeedingConfig and layerNumbering
GraphBasedSeedingConfig and layerNumberingGraphBasedSeedingConfig and layerNumbering function in examples
Contributor
|
OK, so this is just bug fixes? It still crashes due to the vtable export, but the current version would probably crash if it got that far, right? If so, maybe this doesn't need to be |
Contributor
Author
|
Yes this is just the fixes that where hiding the vtable issue from being replicated, but this PR will allow this |
Contributor
Contributor
|
Is this PR still on the cards? no rush, just want to understand the plans. |
andiwand
reviewed
Apr 12, 2026
andiwand
reviewed
Apr 12, 2026
andiwand
approved these changes
Apr 12, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Small PR to fix some bigs with the running of GBTS in standalone which include:
changing
acts.examples.GbtsConfigtoacts.examples.GraphBasedSeedingConfigchange order of function so the ACTS ID to GBTS ID map is parsed before GBTS layers are are created. An extra check was also added to warn the user of any mismatch within the map
--- END COMMIT MESSAGE ---
@timadye @andiwand