Skip to content

fix: bug fixes for GraphBasedSeedingConfig and layerNumbering function in examples #5323

Merged
andiwand merged 5 commits intoacts-project:mainfrom
jpreston-cern:GBTS_bug_fixes
Apr 12, 2026
Merged

fix: bug fixes for GraphBasedSeedingConfig and layerNumbering function in examples #5323
andiwand merged 5 commits intoacts-project:mainfrom
jpreston-cern:GBTS_bug_fixes

Conversation

@jpreston-cern
Copy link
Copy Markdown
Contributor

Small PR to fix some bigs with the running of GBTS in standalone which include:

changing acts.examples.GbtsConfig to acts.examples.GraphBasedSeedingConfig

change order of function so the ACTS ID to GBTS ID map is parsed before GBTS layers are are created. An extra check was also added to warn the user of any mismatch within the map

--- END COMMIT MESSAGE ---

@timadye @andiwand

@jpreston-cern jpreston-cern changed the title fix: bug fixes for "GraphBasedSeedingConfig and layerNumbering` fix: bug fixes for GraphBasedSeedingConfig and layerNumbering Apr 8, 2026
@jpreston-cern jpreston-cern changed the title fix: bug fixes for GraphBasedSeedingConfig and layerNumbering fix: bug fixes for GraphBasedSeedingConfig and layerNumbering function in examples Apr 8, 2026
@github-actions github-actions bot added this to the next milestone Apr 8, 2026
@github-actions github-actions bot added Component - Examples Affects the Examples module Track Finding labels Apr 8, 2026
@timadye
Copy link
Copy Markdown
Contributor

timadye commented Apr 8, 2026

OK, so this is just bug fixes? It still crashes due to the vtable export, but the current version would probably crash if it got that far, right?

If so, maybe this doesn't need to be Draft and could be merged.

@jpreston-cern
Copy link
Copy Markdown
Contributor Author

Yes this is just the fixes that where hiding the vtable issue from being replicated, but this PR will allow this

@jpreston-cern jpreston-cern marked this pull request as ready for review April 8, 2026 15:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

📊: Physics performance monitoring for 397c10b

Full contents

physmon summary

@jpreston-cern jpreston-cern marked this pull request as draft April 9, 2026 10:00
@timadye
Copy link
Copy Markdown
Contributor

timadye commented Apr 11, 2026

Is this PR still on the cards? no rush, just want to understand the plans.

Comment thread Examples/Algorithms/TrackFinding/src/GraphBasedSeedingAlgorithm.cpp Outdated
Comment thread Examples/Algorithms/TrackFinding/src/GraphBasedSeedingAlgorithm.cpp Outdated
@andiwand andiwand marked this pull request as ready for review April 12, 2026 09:28
@sonarqubecloud
Copy link
Copy Markdown

@andiwand andiwand merged commit f397991 into acts-project:main Apr 12, 2026
45 of 46 checks passed
@andiwand andiwand modified the milestones: next, v46.2.0 Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component - Examples Affects the Examples module Track Finding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants