feat: Gen3 DD4hep construction#5193
Open
paulgessinger wants to merge 64 commits intoacts-project:mainfrom
Open
feat: Gen3 DD4hep construction#5193paulgessinger wants to merge 64 commits intoacts-project:mainfrom
paulgessinger wants to merge 64 commits intoacts-project:mainfrom
Conversation
github-actions
bot
added
Component - Core
paulgessinger
force-pushed
the
feat/dd4hep-gen3
branch
from
f4d3d88 to
8538d86
Compare
2 tasks
Contributor
|
From my point of view, I am pretty happy with the state of this. I have exercised a few of the geometries we have in k4geo in key4hep/k4ActsTracking#36 and at least for me the still existing amount of boilerplate is acceptable (and probably also necessary) given the layouts of the tracking devices we have. |
tmadlener
reviewed
Mar 9, 2026
paulgessinger
force-pushed
the
feat/dd4hep-gen3
branch
from
b17a972 to
9acc9b5
Compare
paulgessinger
force-pushed
the
feat/dd4hep-gen3
branch
2 times, most recently
from
65e8d40 to
3d94567
Compare
Contributor
paulgessinger
force-pushed
the
feat/dd4hep-gen3
branch
from
95c300f to
d98d492
Compare
Member
Author
|
It's finally green now @asalzburger @andiwand @tmadlener |
paulgessinger
force-pushed
the
feat/dd4hep-gen3
branch
from
46ce132 to
70a3c8c
Compare
andiwand
previously approved these changes
Apr 7, 2026
Contributor
andiwand
left a comment
andiwand
left a comment
There was a problem hiding this comment.
couple of minor comments and one thought on the general implementation
but overall OK from my side - approving
Move ODD TGeo constants/layer binning logic into the DD4hep builder path and remove the generic TGeoBackend constant-provider plumbing.
paulgessinger
force-pushed
the
feat/dd4hep-gen3
branch
from
70a3c8c to
9b3d65c
Compare
andiwand
previously approved these changes
Apr 13, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.