fix: CMake Code Usage Fix, main branch (2026.02.24.)#5159
fix: CMake Code Usage Fix, main branch (2026.02.24.)#5159krasznaa wants to merge 1 commit intoacts-project:mainfrom
Conversation
|
Though, thinking about it, this may not be a perfect setup either. 😦 You see, anything that Acts needs from LCG in the ATLAS build (like Boost for instance) does need the find-module provided by ATLAS. 🤔 So maybe we just need to accept that the build would be this fragile as part of https://gitlab.cern.ch/atlas/athena/-/blob/main/Projects/WorkDir/ActsOverride.cmake?ref_type=heads. 😦 I wonder if it's just @paulgessinger, let me tag you as well... |
|
Yeah I think the root cause of this that there is no general way on how to configure ONNX in cmake, but that each package needs to provide its on finding which are not necessarily compatible... I think the other possible solution would be to align the cmake finding code, but this is also not great since this could diverge over time again... So probably its the best solution to just hardcode it in the ATLAS build... |
|
2 participants
Made sure that CMake would always select the find-modules present in
cmake/over modules provided by either CMake or the parent project that builds Acts.--- END COMMIT MESSAGE ---
I bumped into this as part of: https://gitlab.cern.ch/atlas/athena/-/merge_requests/86291 That since AthenaExternals also provides a
Findonnxruntime.cmakemodule (https://gitlab.cern.ch/atlas/atlasexternals/-/blob/main/External/onnxruntime/cmake/Findonnxruntime.cmake?ref_type=heads) that behaves differently from the one provided by this project, using FetchContent on top of the Athena project was not working out of the box. 😦Pinging @murnanedaniel and @benjaminhuth.