feat(games): add filtering and pagination to GET /games endpoint by Thisissandy07 · Pull Request #13 · acmpesuecc/ProgChamp

Thisissandy07 · 2026-02-20T17:02:16Z

GET/Games endpoint route

Summary

API endpoint route what allows active users to access games

Type

feat: new feature
refactor: code restructuring

Changes

-pagination added
-filtering of games by likes and date added

Checklist

Code follows project style( I've tried by best to make it match the format of the pre-existing profile and auth routes)
Commit messages follow Conventional Commits
No API keys or sensitive data in code

I have zero idea whether this works or not but iv'e tried to make it as accurate to the db template as possible. Will add filtering later

small edits

Updated the games route to include query parameters for pagination and filtering. Added zod validation. Tried to make it match the format of pre-existed profile and auth routes

ashyune · 2026-02-21T05:33:27Z

@Thisissandy07 do try to follow conventional commits when commit-ing,
also in your PR instead of removing points you can mark them as checked like this - [x] or unchecked - [ ]

as for the code @Rex-8 will review soon

Removed unnecessary queries

Copilot

Pull request overview

This pull request adds a new GET /games endpoint that allows authenticated users to retrieve a paginated list of active games with filtering capabilities.

Changes:

Added a new games route file with GET /games endpoint supporting pagination and filtering by search term, likes count, and creation date
Implemented Zod schema validation for query parameters (page, limit, search, maxLikes, createdAfter, createdBefore)
Added filtering logic for active games with support for title search and date range filtering

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-23T17:53:54Z

+
+    const whereClause = and(...conditions);
+
+/*Data retrival*/


Missing space after comment delimiter. Comment should be formatted as "/* Data retrieval */" to match standard formatting conventions. Also, there's a spelling error: "retrival" should be "retrieval".

Suggested change

/*Data retrival*/

/* Data retrieval */

Copilot · 2026-02-23T17:53:54Z

+/**
+ * GET /games
+ *
+ * gives all active games


The documentation comment has inconsistent capitalization. It should start with a capital letter like other route documentation in the codebase. Change "gives all active games" to "Retrieves all active games" or "Returns all active games" to match the documentation style seen in auth.ts and profile.ts (e.g., "Initiates Google OAuth flow", "Handles Google OAuth callback", "Complete initial profile setup").

Suggested change

* gives all active games

* Retrieves all active games

Copilot · 2026-02-23T17:53:55Z

+ * - createdAfter (YYYY-MM-DD)
+ * - createdBefore (YYYY-MM-DD)
+ *
+


The documentation has an extra blank line at line 45 before the closing comment delimiter. This is inconsistent with the documentation style in other routes (see auth.ts and profile.ts) which don't have blank lines before the closing delimiter. Remove this blank line for consistency.

Suggested change

Copilot · 2026-02-23T17:53:55Z

+ * - page
+ * - limit
+ * - search
+ * - minLikes


The documentation comment mentions 'minLikes' as a query parameter, but this parameter is not defined in the Zod schema (line 19-26) and is not implemented in the filtering logic. Either add the minLikes parameter to the schema and implement the filtering logic, or remove it from the documentation.

Suggested change

* - minLikes

Copilot · 2026-02-23T17:53:56Z

+      const afterTimestamp = Math.floor(
+        new Date(createdAfter).getTime() / 1000,
+      );
+      conditions.push(gte(games.createdAt, afterTimestamp));


When an invalid date string is provided (e.g., "invalid-date"), new Date() will create an Invalid Date object, and getTime() will return NaN. Math.floor(NaN) will also return NaN, which will then be used in the database query and could cause unexpected behavior. The date validation should be improved in the schema (as noted in another comment), or you should add a check here to handle invalid dates and return an appropriate error message.

Copilot · 2026-02-23T17:53:56Z

+      const beforeTimestamp = Math.floor(
+        new Date(createdBefore).getTime() / 1000,
+      );
+      conditions.push(lte(games.createdAt, beforeTimestamp));


When an invalid date string is provided (e.g., "invalid-date"), new Date() will create an Invalid Date object, and getTime() will return NaN. Math.floor(NaN) will also return NaN, which will then be used in the database query and could cause unexpected behavior. The date validation should be improved in the schema (as noted in another comment), or you should add a check here to handle invalid dates and return an appropriate error message.

Copilot · 2026-02-23T17:53:57Z

+    const totalResult = await db
+      .select({ value: count() })
+      .from(games)
+      .where(whereClause);
+
+    const total = totalResult[0]?.value ?? 0;


The total count query runs separately from the main data query, which means two database queries are executed for every request. For large datasets with complex filters, the count query could become a performance bottleneck. Consider adding database indexes on frequently filtered columns (isActive, countLikes, createdAt) to improve query performance. Additionally, for very large datasets, you might want to consider caching the total count or using cursor-based pagination instead of offset-based pagination.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

zod date validation Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Rex-8 · 2026-03-09T13:57:59Z

@Thisissandy07 Is there a reason for choosing offset pagination over cursor pagination.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-12T04:06:27Z

+    if (createdAfter) {
+      const afterTimestamp = Math.floor(
+        new Date(createdAfter).getTime() / 1000,
+      );
+      conditions.push(gte(games.createdAt, afterTimestamp));
+    }
+
+    if (createdBefore) {
+      const beforeTimestamp = Math.floor(
+        new Date(createdBefore).getTime() / 1000,
+      );
+      conditions.push(lte(games.createdAt, beforeTimestamp));
+    }


createdAt is defined as an integer timestamp column with mode: "timestamp" in the schema (used elsewhere with new Date() values). For consistency and to avoid type/serialization issues, compare games.createdAt against Date objects instead of manually converting to epoch seconds. Also, with createdBefore as YYYY-MM-DD, using midnight with lte will exclude most of that day; consider filtering by < startOfNextDay(createdBefore) (or otherwise making the end date inclusive).

Copilot · 2026-03-12T04:06:27Z

+
+export default gamesRoute;


This route is exported but is not currently mounted anywhere in src/index.ts (only /auth and /profile are routed), so GET /games will never be reachable. Add it to the main app router (e.g., app.route("/games", gamesRoute)) to actually expose the endpoint.

Copilot · 2026-03-12T04:14:11Z

@Rex-8 I've opened a new pull request, #31, to work on those changes. Once the pull request is ready, I'll request review from you.

…ll pagination

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Thisissandy07

added cursor based pagination instead of page based. Restructured comments to be more organized

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-12T14:56:00Z

+    const hasNextPage = gamesList.length > limit;
+    const results = hasNextPage ? gamesList.slice(0, limit) : gamesList;
+    const nextCursor = hasNextPage ? results[results.length - 1].createdAt : null;
+
+    return c.json({
+      success: true,
+      limit,
+      nextCursor,
+      games: results,


nextCursor is returned as results[...].createdAt. If createdAt is a Date, the JSON response will contain an ISO string cursor, but the request schema currently expects a numeric cursor, so the next request will fail validation. Make the response and request cursor formats consistent.

You can try returning the timestamps as numbers instead of ISO strings.

Thisissandy07 added 3 commits February 14, 2026 17:06

Add files via upload

e771176

I have zero idea whether this works or not but iv'e tried to make it as accurate to the db template as possible. Will add filtering later

Update game.ts

5b085b1

small edits

Enhance games route with pagination and filtering

96cda3d

Updated the games route to include query parameters for pagination and filtering. Added zod validation. Tried to make it match the format of pre-existed profile and auth routes

mebinthattil requested a review from Rex-8 February 20, 2026 18:32

Refactor game route to simplify query parameters

5610883

Removed unnecessary queries

Thisissandy07 changed the title ~~Sandy~~ feat(games): add filtering and pagination to GET /games endpoint Feb 22, 2026

mebinthattil requested a review from Copilot February 23, 2026 17:48

Copilot started reviewing on behalf of mebinthattil February 23, 2026 17:48 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

Rex-8 and others added 4 commits February 24, 2026 14:46

fix: exporting-games

230f469

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update backend/src/routes/game.ts

f4874bf

zod date validation Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update backend/src/routes/game.ts

85f190f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestion from @Copilot

1718845

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Rex-8 requested a review from Copilot March 12, 2026 04:03

Copilot started reviewing on behalf of Rex-8 March 12, 2026 04:03 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

Copilot AI mentioned this pull request Mar 12, 2026

[WIP] [WIP] Address feedback on filtering and pagination for GET /games endpoint #31

Closed

4 tasks

Thisissandy07 and others added 2 commits March 12, 2026 20:14

refactor(games): replace page-based pagination with cursor-based scro…

031295e

…ll pagination

refactor(games) : comment fix

cf7a665

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Thisissandy07 commented Mar 12, 2026

View reviewed changes

Rex-8 requested a review from Copilot March 12, 2026 14:51

Copilot started reviewing on behalf of Rex-8 March 12, 2026 14:52 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

zia0307 approved these changes Mar 13, 2026

View reviewed changes

Rex-8 merged commit 0b0c3cc into dev Mar 14, 2026
4 checks passed

Thisissandy07 deleted the sandy branch April 3, 2026 05:09

Conversation

Thisissandy07 commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GET/Games endpoint route

Summary

Type

Changes

Checklist

Uh oh!

ashyune commented Feb 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Rex-8 commented Mar 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Mar 12, 2026

Uh oh!

Thisissandy07 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

zia0307 Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

Thisissandy07 commented Feb 20, 2026 •

edited

Loading