Implement calendar changes #293

balaktsis · 2025-11-18T19:12:45Z

Not prod-ready. Opened PR for further discussion

Removed guide and analytics options from settings.

Removed console log from isAuthenticated method.

Removed unnecessary console logs during loading of persisted stores.

Copilot

Pull request overview

This PR implements a significant refactoring of the calendar functionality along with various configuration and authentication updates. The changes are marked as "Not prod-ready" and are opened for discussion, which is appropriate given the scope of modifications.

Key Changes:

Complete calendar UI/UX overhaul with new grid-based month view and modular component architecture
Authentication domain migration from aristomate.gr to aristomate.auth.gr with OAuth scope changes
Metro scraper switched from API-based to direct web scraping approach
Code formatting standardization changes (tabs to spaces)

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 19 comments.

Show a summary per file

File	Description
`src/routes/pages/calendar/+page.svelte`	Major refactoring: replaced swipe-based day navigation with calendar grid view, removed exam fetching, restructured event management
`src/lib/components/calendar/CalendarGrid.svelte`	New component implementing month-view calendar grid with day selection
`src/lib/components/calendar/calendarUtils.ts`	New utility functions for calendar week building and date navigation
`src/lib/components/calendar/calendarState.ts`	New (unused) calendar state management module
`src/lib/components/calendar/event/EventModal.svelte`	New modal component extracted from main calendar page for event creation/editing
`src/lib/components/calendar/event/EventCard.svelte`	UI improvements with better styling, spacing fixes, and conditional description rendering
`src/lib/authentication/OIDCClient.ts`	Modified state parameter handling and simplified refresh token validation logic
`src/app.config.ts`	Domain changes, added `offline_access` scope, removed metro API config, added platform detection flags
`src/lib/storage/capacitorPersistedStore.ts`	Added explicit Preferences writes in set/update methods
`src/routes/persistedStoreDeclarations.ts`	Minor formatting change and unused import added
`src/lib/metroScraper/scraper.ts`	Switched from API consumption to direct web scraping
`src/lib/components/map/map.svelte`	Fixed import typo, formatting improvements
`src/routes/pages/homepage/homepage.svelte`	Added platform-conditional webmail login visibility
`src/lib/components/webmailLogin/*`	Added platform-conditional rendering for Android/development only
`src/lib/components/personalInfo/settings.svelte`	Removed guide and analytics menu items
`src/lib/translations/translations.js`	Added metro error messages and new calendar no-events message
`android/app/src/main/AndroidManifest.xml`	Added intent filter for new `aristomate.auth.gr` domain
`src/app.html`	Added Cloudflare Web Analytics scripts (two different tokens)
`.prettierrc`	Changed from tabs to spaces with 4-space indentation

Comments suppressed due to low confidence (1)

src/routes/persistedStoreDeclarations.ts:10

Unused import get.

import { get } from "svelte/store";

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-04T13:01:10Z

src/lib/components/calendar/event/EventCard.svelte

 					{#if eventItem.slot.end && new Date(eventItem.slot.end).getTime() != new Date(eventItem.slot.start).getTime()}
 						{#if new Date(eventItem.slot.end).getDay() - new Date(eventItem.slot.start).getDay() != 0}
-							&nbsp-*
+							&nbsp;-*


[nitpick] Inconsistent non-breaking space usage. Line 70 uses  -* while line 72 uses  -  with spaces around the dash. For consistency, consider using   on both sides of the dash in both cases.

Suggested change

 -*

 - *

Copilot · 2025-12-04T13:01:11Z

src/lib/components/calendar/calendarUtils.ts

+    return Array.from({ length: 7 }, (_, i) => {
+        const date = new Date(2024, 0, i);


[nitpick] Hardcoded year in weekday name generation. The function uses new Date(2024, 0, i) to generate weekday names. This will work correctly, but consider using a dynamic approach or adding a comment explaining why 2024 is used (likely just as a reference year for getting weekday names).

Suggested change

return Array.from({ length: 7 }, (_, i) => {

const date = new Date(2024, 0, i);

// Use current year to avoid hardcoding and ensure future-proofing

const currentYear = new Date().getFullYear();

return Array.from({ length: 7 }, (_, i) => {

const date = new Date(currentYear, 0, i);

Copilot · 2025-12-04T13:01:11Z

src/app.html

 		<link rel="icon" href="%sveltekit.assets%/favicon.png" />
 		<meta name="viewport" content="width=device-width, initial-scale=1" />
+		<!-- Cloudflare Web Analytics --><script defer src='https://static.cloudflareinsights.com/beacon.min.js' data-cf-beacon='{"token": "9a78acf6d3c44e1ba7b4805affdc9c57"}'></script><!-- End Cloudflare Web Analytics -->
+		<!-- Cloudflare Web Analytics --><script defer src='https://static.cloudflareinsights.com/beacon.min.js' data-cf-beacon='{"token": "aa5ba1d501724ca1af72ab16c6a2af1a"}'></script><!-- End Cloudflare Web Analytics -->


Duplicate Cloudflare Web Analytics scripts. Two different analytics scripts with different tokens are loaded on the same page. This could lead to duplicate tracking or conflicts. Consider consolidating to a single token or explaining why multiple tokens are needed.

Suggested change

<script defer src='https://static.cloudflareinsights.com/beacon.min.js' data-cf-beacon='{"token": "aa5ba1d501724ca1af72ab16c6a2af1a"}'></script>

Copilot · 2025-12-04T13:01:12Z

src/lib/authentication/OIDCClient.ts

+    // const state = this.generateRandomString();
+    const state = encodeURIComponent(btoa(`{"production":${this.config.isProduction}}`));


Hardcoded production state in authorization URL. The state parameter now encodes the production flag as {"production":${this.config.isProduction}}. This is unusual - the state parameter is typically used for CSRF protection and should be a random value. Encoding application state here could be a security concern. If you need to pass the production flag, consider using a separate custom parameter or including it in the redirect URI.

Copilot · 2025-12-04T13:01:12Z

src/routes/pages/calendar/+page.svelte

+                setTimeout(() => {
+                    selectedDay = { day: dayObj.day, month, year };
+                    activeDate = new Date(year, month, dayObj.day);
+                }, 0);


[nitpick] Potential navigation timing issue. When selecting a day from a different month (lines 60-65), the month is changed and then a setTimeout with 0ms delay is used to set the selectedDay. This setTimeout is likely used to ensure the calendar rebuilds before selecting the day, but it's fragile. Consider using a reactive statement or ensuring the selection happens after the calendar rebuild in a more deterministic way.

Copilot · 2025-12-04T13:01:14Z

src/routes/persistedStoreDeclarations.ts

 import { scheduledNotifications } from "$lib/calendarNotifications/notificationsStore";
 import { loginStore } from "$src/lib/authentication/loginStore";
 import { userCredsFlag } from "$components/webmailLogin/userCredsFlagStore";
+import { get } from "svelte/store";


Unused import. The get function from 'svelte/store' is imported but not used anywhere in this file.

Suggested change

import { get } from "svelte/store";

Copilot · 2025-12-04T13:01:15Z

src/routes/persistedStoreDeclarations.ts

    console.log('Loading persisted stores');
-    persistedStores.forEach(async (store) => await store.loadFromStorage());
-}
+    persistedStores.forEach(async (store) => { await store.loadFromStorage();});


Potential issue with async forEach. Using forEach with async callbacks doesn't wait for promises to complete. The function returns before all stores finish loading. Consider using Promise.all() with map() instead:

await Promise.all(persistedStores.map(store => store.loadFromStorage()));

Suggested change

persistedStores.forEach(async (store) => { await store.loadFromStorage();});

await Promise.all(persistedStores.map(store => store.loadFromStorage()));

Copilot · 2025-12-04T13:01:15Z

src/app.config.ts

+        redirectUri: 'https://applink.aristomate.auth.gr/authsso/callback',
+        scope: 'students:read offline_access',
        isMobile: isMobile,
        // Use proxy for web
-        tokenUrl: isMobile ? undefined : 'https://applink.aristomate.gr/api/auth/token'
+        tokenUrl: isMobile ? undefined : 'https://applink.aristomate.auth.gr/api/auth/token',


Domain name discrepancy. The redirect URI and token URL domains have changed from applink.aristomate.gr to applink.aristomate.auth.gr. Ensure that:

The new domain is properly configured and accessible

OAuth provider is configured to accept this new redirect URI

SSL certificates are valid for the new domain

Copilot · 2025-12-04T13:01:15Z

.prettierrc

+	"useTabs": false,
+	"tabWidth": 4,


[nitpick] Significant formatting change. Switching from tabs to spaces (with 4-space indentation) is a major change that will affect the entire codebase formatting. This should be applied consistently across all files, ideally in a separate commit/PR dedicated to formatting changes only. Mixing formatting changes with functional changes makes code review more difficult.

Copilot · 2025-12-04T13:01:16Z

src/lib/components/calendar/calendarState.ts

@@ -0,0 +1,44 @@
+import { writable, derived } from 'svelte/store';


Unused import derived.

Suggested change

import { writable, derived } from 'svelte/store';

import { writable } from 'svelte/store';

balaktsis and others added 18 commits November 18, 2025 21:11

Implement calendar changes

fd22fda

Remove guide and analytics items from settings

c88eea9

Removed guide and analytics options from settings.

Made sure to hide the webmail login banner in case it is not implemented

6844e41

Made webmail login visible again for dev

ffdf9be

Added cloudflare analytics

d7aa88f

Tempfix for metro

a61ea31

Fix typo in metroInfo message

d8f2955

Added functional state parsing to clean up the production redirect page

3528443

Added offline access scope

8c1ab83

Updates in the refresh token logic

11f4d59

Fixed persistent stores not syncing

15d83f7

Remove console log from isAuthenticated method

18fe2a5

Removed console log from isAuthenticated method.

Clean up console logs in loadPersistedStores function

47265cc

Removed unnecessary console logs during loading of persisted stores.

Fixed metro state scraping

de54197

Restored scraping

a8c5022

Restored scraping

0e80f96

Updated to new applink

fae1135

Updated to new api

a63a5dd

Copilot AI review requested due to automatic review settings December 4, 2025 12:52

Copilot started reviewing on behalf of neron-png December 4, 2025 12:52 View session

Copilot finished reviewing on behalf of neron-png December 4, 2025 12:56

Copilot AI reviewed Dec 4, 2025

View reviewed changes

Changed buttons in grid

c1bbaa6

neron-png closed this Dec 4, 2025

neron-png reopened this Dec 4, 2025

Fixed today's css

66130b5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement calendar changes #293

Implement calendar changes #293

Uh oh!

balaktsis commented Nov 18, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		return Array.from({ length: 7 }, (_, i) => {
		const date = new Date(2024, 0, i);

		// const state = this.generateRandomString();
		const state = encodeURIComponent(btoa(`{"production":${this.config.isProduction}}`));

	persistedStores.forEach(async (store) => { await store.loadFromStorage();});
	await Promise.all(persistedStores.map(store => store.loadFromStorage()));

		@@ -0,0 +1,44 @@
		import { writable, derived } from 'svelte/store';

	import { writable, derived } from 'svelte/store';
	import { writable } from 'svelte/store';

Implement calendar changes #293

Are you sure you want to change the base?

Implement calendar changes #293

Uh oh!

Conversation

balaktsis commented Nov 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants