feat: support passing extra parameters and using different documents #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
support-doc
branch
8 times, most recently
from
7e56179 to
7cf0766
Compare
G-Rath
requested review from
JacobBriggsAckama,
eoinkelly,
halles,
joshmcarthur,
lukeify and
robotdana
JacobBriggsAckama
approved these changes
Oct 15, 2025
joshmcarthur
approved these changes
Oct 31, 2025
nzlaura
approved these changes
Oct 31, 2025
G-Rath
force-pushed
the
support-doc
branch
3 times, most recently
from
2edc1ad to
9714b1a
Compare
G-Rath
force-pushed
the
support-doc
branch
2 times, most recently
from
6fd5c5c to
e4efac9
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds support for using alternative AWS Systems Manager documents and passing extra parameters to SsmPortForwardingSession, enabling more advanced use cases like tunneling through an EC2 instance to access private RDS databases.
Key changes:
- Added
documentandextra_paramsoptional parameters toSsmPortForwardingSession.new - Extra parameters are merged with required parameters, with explicit parameters taking precedence
- Documentation and tests demonstrate using
AWS-StartPortForwardingSessionToRemoteHostfor database access
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
lib/aws_ec2_environment/ssm_port_forwarding_session.rb |
Added document and extra_params parameters to initialize method and updated ssm_port_forward_cmd to use them |
sig/aws_ec2_environment/ssm_port_forwarding_session.rbs |
Updated type signatures for new parameters and private method |
spec/aws_ec2_environment/ssm_port_forwarding_session_spec.rb |
Added comprehensive test coverage for custom documents, extra parameters, and parameter overriding |
README.md |
Added example demonstrating database access through SSM tunneling with custom document and parameters |
CHANGELOG.md |
Documented the new feature in the unreleased section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the new section of the readme for why this is useful 🙂