Skip to content

[dataquery] Translate dataquery module #10048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[dataquery] Translate dataquery module #10048

wants to merge 5 commits into from

Conversation

SKADE2303
Copy link
Collaborator

This PR is responsible for translating the module dataquery to different languages. Currently only 'Hindi' language is supported but other languages can be added as required.

Testing instructions (if applicable)

  1. Run 'make dev' to load changes
  2. Change language_preference to Hindi in my_preferences Tab
  3. Go to dataquery tab to see translated web page.

@github-actions github-actions bot added Language: Javascript PR or issue that update Javascript code Module: dataquery PR or issue related to (new) dataquery module labels Oct 14, 2025
@SKADE2303 SKADE2303 added Event: GSOC PR or issue accepted for Google Summer of Code Multilingual Any tasks related to making LORIS multilingual Language: Javascript PR or issue that update Javascript code Module: dataquery PR or issue related to (new) dataquery module and removed Language: Javascript PR or issue that update Javascript code Module: dataquery PR or issue related to (new) dataquery module labels Oct 14, 2025
@SKADE2303 SKADE2303 marked this pull request as ready for review October 14, 2025 21:28
driusan
driusan reviewed Oct 15, 2025
View reviewed changes
modules/dataquery/jsx/hooks/usebreadcrumbs.tsx Outdated
const breadcrumbs = [
{
text: 'Data Query Tool (Beta)',
text: t('Data Query Tool (Beta', {ns: 'dataquery'}),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The closing bracket around "(Beta" seems to be missing.

@racostas racostas self-requested a review October 16, 2025 07:00
racostas
racostas requested changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module don't seems to be loading for my after this PR.
I got some errors in the webrowser console.
image

image

@racostas racostas added the State: Needs work PR awaiting additional work by the author to proceed label Oct 16, 2025
@racostas racostas removed the State: Needs work PR awaiting additional work by the author to proceed label Oct 17, 2025
@racostas racostas self-requested a review October 17, 2025 14:58
racostas
racostas requested changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good advances @SKADE2303 !

Some translations that are still missing:
image

image image image image

@racostas racostas added Multilingual Any tasks related to making LORIS multilingual State: Needs work PR awaiting additional work by the author to proceed and removed Multilingual Any tasks related to making LORIS multilingual labels Oct 17, 2025
@SKADE2303 SKADE2303 force-pushed the TranslateDataquery branch 3 times, most recently from 0481dcb to 8bfd4b7 Compare October 17, 2025 18:34
@SKADE2303 SKADE2303 removed the State: Needs work PR awaiting additional work by the author to proceed label Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driusan driusan driusan left review comments

@racostas racostas racostas requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@SKADE2303 SKADE2303

Labels

Event: GSOC PR or issue accepted for Google Summer of Code Language: Javascript PR or issue that update Javascript code Module: dataquery PR or issue related to (new) dataquery module Multilingual Any tasks related to making LORIS multilingual

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SKADE2303 @driusan @racostas