fix(deps): declare python-multipart as a direct dependency - #1275
Conversation
The API server uses FastAPI UploadFile/Form endpoints (acestep/api/route_setup.py, acestep/api/http/release_task_audio_paths.py), which require python-multipart at route-definition time. It currently arrives only transitively through gradio, so installs without gradio (headless API deployments) fail on import. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Caution Review failedAn error occurred during the review process. Please try again later. 📝 WalkthroughWalkthroughAdds ChangesMultipart dependency update
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ency Upstreamed as ace-step/ACE-Step-1.5#1275 (with #1276 for the headless api_server patch already on fork main). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fork commit 342a019, upstreamed as ace-step/ACE-Step-1.5#1275 (#1276 carries the headless api_server patch). Lock records the new ace-step requirement; already satisfied by our own direct declaration. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Thanks for the clean dependency fix. I checked this locally in a temporary worktree and Could you please include the corresponding |
Adds the direct dependency edge and requires-dist entry for python-multipart>=0.0.18 on the ace-step package, matching the pyproject.toml change. The locked version (0.0.22, already resolved via gradio) is unchanged. Verified with 'uv lock --check'. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MGYzKnqg6ti5DENrxcfwnp
Summary
The API server uses FastAPI
UploadFile/Formendpoints (acestep/api/route_setup.py,acestep/api/http/release_task_audio_paths.py), which requirepython-multipartat route-definition time. It is currently only present transitively throughgradio, so any install without gradio (e.g. a headless API-server deployment) fails at import with FastAPI's "Form data requires python-multipart" error.This declares it explicitly in
pyproject.tomlandrequirements.txt. No behavior change for existing installs — the package is already present in any environment that has gradio.Complementary to #1276 (making
acestep.api_serverimportable without gradio), which is the scenario that exposes this gap — but this fix stands on its own: load-bearing dependencies should be declared, not inherited.🤖 Generated with Claude Code
Summary by CodeRabbit