Skip to content

fix(deps): declare python-multipart as a direct dependency - #1275

Open
tsondo wants to merge 2 commits into
ace-step:mainfrom
tsondo:pr/declare-python-multipart
Open

fix(deps): declare python-multipart as a direct dependency#1275
tsondo wants to merge 2 commits into
ace-step:mainfrom
tsondo:pr/declare-python-multipart

Conversation

@tsondo

@tsondo tsondo commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

The API server uses FastAPI UploadFile/Form endpoints (acestep/api/route_setup.py, acestep/api/http/release_task_audio_paths.py), which require python-multipart at route-definition time. It is currently only present transitively through gradio, so any install without gradio (e.g. a headless API-server deployment) fails at import with FastAPI's "Form data requires python-multipart" error.

This declares it explicitly in pyproject.toml and requirements.txt. No behavior change for existing installs — the package is already present in any environment that has gradio.

Complementary to #1276 (making acestep.api_server importable without gradio), which is the scenario that exposes this gap — but this fix stands on its own: load-bearing dependencies should be declared, not inherited.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Added support for multipart form data handling.
    • Updated the project’s runtime requirements to include the necessary multipart-processing package.

The API server uses FastAPI UploadFile/Form endpoints
(acestep/api/route_setup.py, acestep/api/http/release_task_audio_paths.py),
which require python-multipart at route-definition time. It currently
arrives only transitively through gradio, so installs without gradio
(headless API deployments) fail on import.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

An error occurred during the review process. Please try again later.

📝 Walkthrough

Walkthrough

Adds python-multipart>=0.0.18 to the project metadata and requirements dependency lists.

Changes

Multipart dependency update

Layer / File(s) Summary
Add multipart dependency
pyproject.toml, requirements.txt
Both dependency declarations now include python-multipart>=0.0.18.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

I’m a rabbit with packages to pack,
Multipart hops into the stack.
Two lists now agree,
Versioned neatly,
And dependencies stay on track!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding python-multipart as a direct dependency.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

tsondo added a commit to tsondo/Ace-Step-Wrangler that referenced this pull request Jul 27, 2026
…ency

Upstreamed as ace-step/ACE-Step-1.5#1275 (with #1276 for the headless
api_server patch already on fork main).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
tsondo added a commit to tsondo/StemForge that referenced this pull request Jul 27, 2026
Fork commit 342a019, upstreamed as ace-step/ACE-Step-1.5#1275 (#1276
carries the headless api_server patch). Lock records the new ace-step
requirement; already satisfied by our own direct declaration.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@ChuxiJ

ChuxiJ commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Thanks for the clean dependency fix. I checked this locally in a temporary worktree and uv lock --check reports that uv.lock needs to be updated after adding python-multipart>=0.0.18.

Could you please include the corresponding uv.lock update in this PR? After that this should be straightforward to merge.

Adds the direct dependency edge and requires-dist entry for
python-multipart>=0.0.18 on the ace-step package, matching the
pyproject.toml change. The locked version (0.0.22, already resolved
via gradio) is unchanged. Verified with 'uv lock --check'.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MGYzKnqg6ti5DENrxcfwnp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants