test: Add regression test for key balance read returning zero#387
Closed
AbuJulaybeeb wants to merge 1 commit into
Closed
test: Add regression test for key balance read returning zero#387AbuJulaybeeb wants to merge 1 commit into
AbuJulaybeeb wants to merge 1 commit into
Conversation
|
@AbuJulaybeeb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new regression test
test_key_balance_read_returns_zero_for_address_with_no_buystocreator-keys/tests/key_balance.rs. This explicitly tests querying the key balance using a distinct, uninitialized wallet address that has not interacted with the contract.Why it was done
To resolve #369 by guaranteeing that a valid wallet address that has never bought keys for a creator returns a zero balance natively. This confirms the read handles uninitialized holders gracefully rather than producing unexpected panics, errors, or null states.
How it was verified
The regression test initializes the environment, registers a creator, simulates an active buyer interacting with the contract, and queries the
inactive_wallet. It successfully asserts thatclient.get_key_balance(&creator, &inactive_wallet)evaluates to0without throwing any errors.Closes #369