feat(keyboard): add keyboard shortcut system for power users (#856) - #869
Merged
Chucks1093 merged 6 commits intoSep 3, 2026
Merged
Conversation
…ayerorg#856) Implement a global keyboard-shortcut system that lets power users trigger common actions without reaching for the mouse. Global shortcuts (dialog closed): / → focus marketplace search input B → open buy modal S → open sell modal P → navigate to portfolio page T → open trade dialog (buy) 1–4 → switch profile tabs (overview, creations, collectors, activity) ? → toggle keyboard-shortcuts help modal Ctrl+R → refresh creator list Dialog shortcuts: Enter → confirm trade (when form is valid) Esc → close dialog (Radix native) Amount shortcuts (amount input focused): +/- → adjust amount by 1 1–5 → quick presets (1, 2, 3, 5, 10) All shortcuts are disabled when focus is inside an input, textarea, or contenteditable element to avoid conflicts with normal typing. New files: - useTradeKeyboardShortcuts hook (centralised shortcut manager) - KeyboardShortcutsHelp dialog (triggered by ?) - TradeShortcutHints floating indicator (auto-dismisses) Modified files: - TradeDialog: internal amount shortcuts, shortcut hint bar - SearchBar: added data-testid for keyboard targeting - LandingPage: wired up all shortcuts via the centralised hook Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@meem08 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
The <Kbd> component had a lowercase </kbd> closing tag which caused an ESLint parse error in CI. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Another lowercase </kbd> closing tag that should be </Kbd>, causing ESLint parse errors in CI. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Extract TradeShortcut type, avoid readonly array push issue, and use a cleaner lookup pattern. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Contributor
Author
|
@Chucks1093 review and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a global keyboard-shortcut system that lets power users trigger common actions without reaching for the mouse.
closes #856
Global shortcuts (dialog closed):
/ → focus marketplace search input
B → open buy modal
S → open sell modal
P → navigate to portfolio page
T → open trade dialog (buy)
1–4 → switch profile tabs (overview, creations, collectors, activity)
? → toggle keyboard-shortcuts help modal
Ctrl+R → refresh creator list
Dialog shortcuts:
Enter → confirm trade (when form is valid)
Esc → close dialog (Radix native)
Amount shortcuts (amount input focused):
+/- → adjust amount by 1
1–5 → quick presets (1, 2, 3, 5, 10)
All shortcuts are disabled when focus is inside an input, textarea, or contenteditable element to avoid conflicts with normal typing.
New files:
Modified files:
Summary
Testing
pnpm lintpnpm buildChecklist