fix: validate batch buy liquid balance - #836
Merged
Merged
Conversation
|
@samjay8 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #832
Summary
Scope
Does not change the separate marketing-links issue (#428) or unrelated batch-buy behavior.
Testing
corepack pnpm exec vitest run src/components/common/__tests__/BatchBuyModal.test.tsx— passed (5 tests)corepack pnpm lint— passedcorepack pnpm build— passedcorepack pnpm format:check— pre-existing baseline failure across upstream dev filesFiles changed
src/components/common/BatchBuyModal.tsx— add balance/address validation and submit normalization.src/components/common/__tests__/BatchBuyModal.test.tsx— cover issue Add unit tests for the batch transfer modal validating that the total quantity cannot exceed the liquid balance #832 acceptance criteria.src/hooks/useWallet.ts— align batch mutation order type with address/quantity contract.