Skip to content

Update project link #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reza-2029 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update project link #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb62ce0
test commit
reza-2029 Oct 5, 2025
8d638f9
add links to the projects
reza-2029 Oct 19, 2025
b83c45a
added styles to project links
reza-2029 Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
--text-color: #000000;
--accent-color: #F8E0C9;
--font-family: 'Inter', sans-serif;
--mammoth-purple: #3F1F69;
}

html, body {
Expand Down Expand Up @@ -230,6 +231,12 @@ header {
color: var(--secondary-color);
}

.index-card a.secondary-link {
color: var(--mammoth-purple);
}



/* Startup link styles */
.startup-link {
display: inline-block;
Expand Down
7 changes: 7 additions & 0 deletions startups.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,13 @@ <h4>Contact</h4>
a.textContent = startup.github_text;
infoDiv.appendChild(a);

const a2 = document.createElement('a');
a2.href = startup.test_url;
a2.textContent = startup.test_text;
a2.className = 'secondary-link';
Comment on lines +149 to +152

@korbit-ai korbit-ai Bot Oct 19, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear link hierarchy documentation category Documentation

Tell me more
What is the issue?

The purpose of the secondary link and its relationship to the primary GitHub link is not documented.

Why this matters

The distinction between the two links and why one has a 'secondary-link' class is unclear, making it difficult to maintain consistent UI patterns.

Suggested change ∙ Feature Preview

// Create secondary action link (e.g., demo/test link)
const a2 = document.createElement('a');
a2.href = startup.test_url;
a2.textContent = startup.test_text;
a2.className = 'secondary-link';

Provide feedback to improve future suggestions

Nice Catch Incorrect Not in Scope Not in coding standard Other

💬 Looking for more details? Reply to this comment to chat with Korbit.

infoDiv.appendChild(document.createElement('br'));
infoDiv.appendChild(a2);
Comment on lines +149 to +154

@korbit-ai korbit-ai Bot Oct 19, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing null checks for secondary link properties category Functionality

Tell me more
What is the issue?

The code creates secondary links without checking if startup.test_url and startup.test_text exist, which will create broken links with undefined href and text when these properties are missing from the JSON data.

Why this matters

This will result in anchor elements with href="undefined" and textContent="undefined" being rendered on the page, creating a poor user experience and potentially broken functionality when users click on these malformed links.

Suggested change ∙ Feature Preview

Add conditional checks before creating the secondary link:

if (startup.test_url && startup.test_text) {
  const a2 = document.createElement('a');
  a2.href = startup.test_url;
  a2.textContent = startup.test_text;
  a2.className = 'secondary-link';
  infoDiv.appendChild(document.createElement('br'));
  infoDiv.appendChild(a2);
}
Provide feedback to improve future suggestions

Nice Catch Incorrect Not in Scope Not in coding standard Other

💬 Looking for more details? Reply to this comment to chat with Korbit.


card.appendChild(infoDiv);
container.appendChild(card);
});
Expand Down