Skip to content

Fix ability to define falsy value #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix ability to define falsy value #788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/get-metadata.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,11 @@ test('when defined on prototype with a property key', () => {
Reflect.defineMetadata('key', 'value', prototype, 'name');
expect(Reflect.getMetadata('key', target, 'name')).toEqual('value');
});

test('when value is falsy', () => {
const target = {};
const value = 0;

Reflect.defineMetadata('key', value, target, 'name');
expect(Reflect.getMetadata('key', target, 'name')).toEqual(value);
});
14 changes: 7 additions & 7 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,14 +125,14 @@ function ordinaryGetMetadata<MetadataValue>(
target: Target,
propertyKey?: PropertyKey,
): MetadataValue | undefined {
return ordinaryGetOwnMetadata<MetadataValue>(metadataKey, target, propertyKey)
return ordinaryGetOwnMetadata<MetadataValue>(metadataKey, target, propertyKey) !== undefined
? ordinaryGetOwnMetadata<MetadataValue>(metadataKey, target, propertyKey)
: Object.getPrototypeOf(target)
? ordinaryGetMetadata(
metadataKey,
Object.getPrototypeOf(target),
propertyKey,
)
metadataKey,
Object.getPrototypeOf(target),
propertyKey,
)
: undefined;
}

Expand Down Expand Up @@ -175,15 +175,15 @@ export function hasOwnMetadata(
target: Target,
propertyKey?: PropertyKey,
): boolean {
return !!ordinaryGetOwnMetadata(metadataKey, target, propertyKey);
return ordinaryGetOwnMetadata(metadataKey, target, propertyKey) !== undefined;
}

export function hasMetadata(
metadataKey: MetadataKey,
target: Target,
propertyKey?: PropertyKey,
): boolean {
return !!ordinaryGetMetadata(metadataKey, target, propertyKey);
return ordinaryGetMetadata(metadataKey, target, propertyKey) !== undefined;
}

export function defineMetadata<MetadataValue>(
Expand Down