Add label to toggle's input for accessibility#186
Open
FarisMarouane wants to merge 1 commit intoaaronshaf:masterfrom
Open
Add label to toggle's input for accessibility#186FarisMarouane wants to merge 1 commit intoaaronshaf:masterfrom
FarisMarouane wants to merge 1 commit intoaaronshaf:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running Web vitals test on a web page using react-toggle, the test complains that there's no accompanying label to the input.
You could surround the Toggle component with a label tag, but it messes up with the styling.
I am talking of cases where you don't need any visible label (before the toggle for instance).
This PR just add a label tag, with the already existing css class "react-toggle-screenreader-only"; before the input element when an id prop is specified. This is done to improve the library accessibility.
Thank you !