Skip to content

refactor: Separate protobuf dependencies into sensible extras #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

refactor: Separate protobuf dependencies into sensible extras #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c3cef00
Separate protobuf dependencies
vinoo999 Oct 23, 2025
8ffaa43
fix google-api-core as well
vinoo999 Oct 24, 2025
0e23416
re-order dependencies
vinoo999 Oct 24, 2025
16ab7cc
patch to readme, remove rest-server extra
vinoo999 Oct 24, 2025
9a8fe5d
Merge branch 'main' into split_proto_deps
vinoo999 Oct 24, 2025
66b42d1
Update README.md
vinoo999 Oct 27, 2025
b956806
remove proto extra, consolidate in http-server, grpc
vinoo999 Nov 3, 2025
965c371
Update README.md
vinoo999 Nov 3, 2025
285ff7a
Update proto_utils.py
vinoo999 Nov 3, 2025
09bb4f1
Merge branch 'main' into split_proto_deps
vinoo999 Nov 3, 2025
4be36ea
Merge branch 'main' into split_proto_deps
vinoo999 Nov 12, 2025
b7e2c71
Update README.md
vinoo999 Nov 19, 2025
5813558
Merge branch 'main' into split_proto_deps
vinoo999 Nov 19, 2025
30af48b
revert spelling allow.txt
vinoo999 Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/actions/spelling/allow.txt
View file
Open in desktop
Copy link
Member

@lkawka lkawka Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why make changes to this file? It appears that entires were in an alphabetical order here.

Copy link
Author

@vinoo999 vinoo999 Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unclear. i think this came directly from the github action when updating readme. i can revert

Copy link
Author

@vinoo999 vinoo999 Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in fact I think this may have come from the Format script which must have a bug for capitalization

Copy link
Author

@vinoo999 vinoo999 Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/a2aproject/a2a-python/pull/550### to address

Copy link
Author

@vinoo999 vinoo999 Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reran with ^ and applied. removed postres dup

Copy link
Member

@lkawka lkawka Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave it as it was? I'm not entirely familiar with how this file is used and I worry that dependents may be case-sensitive.

Copy link
Member

@holtskinner holtskinner Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intentionally left case-sensitive, because the case-insensitive sort wasn't always consistent.

Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ oauthoidc
oidc
opensource
otherurl
postgres
POSTGRES
postgresql
protoc
Expand Down
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ Install the core SDK and any desired extras using your preferred package manager
| ------------------------ | ------------------------------------------ | -------------------------------------------- |
| **Core SDK** | `uv add a2a-sdk` | `pip install a2a-sdk` |
| **All Extras** | `uv add "a2a-sdk[all]"` | `pip install "a2a-sdk[all]"` |
| **HTTP Server** | `uv add "a2a-sdk[http-server]"` | `pip install "a2a-sdk[http-server]"` |
| **JSON-RPC Server** | `uv add "a2a-sdk[jsonrpc-server]"` | `pip install "a2a-sdk[jsonrpc-server]"` |
| **HTTP+JSON/REST Server** | `uv add "a2a-sdk[http-server]"` | `pip install "a2a-sdk[http-server]"` |
| **gRPC Support** | `uv add "a2a-sdk[grpc]"` | `pip install "a2a-sdk[grpc]"` |
| **OpenTelemetry Tracing**| `uv add "a2a-sdk[telemetry]"` | `pip install "a2a-sdk[telemetry]"` |
| **Encryption** | `uv add "a2a-sdk[encryption]"` | `pip install "a2a-sdk[encryption]"` |
Expand Down
7 changes: 3 additions & 4 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ dependencies = [
"httpx>=0.28.1",
"httpx-sse>=0.4.0",
"pydantic>=2.11.3",
"protobuf>=5.29.5",
"google-api-core>=1.26.0",
]

classifiers = [
Expand All @@ -29,9 +27,10 @@ classifiers = [
]

[project.optional-dependencies]
http-server = ["fastapi>=0.115.2", "sse-starlette", "starlette"]
jsonrpc-server = ["fastapi>=0.115.2", "sse-starlette", "starlette"]
http-server = ["a2a-sdk[jsonrpc-server]", "protobuf>=5.29.5"]
Copy link
Member

@lkawka lkawka Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTP+JSON/REST also requires these dependencies.

rest_handler.py depends on a2a_pb2:

a2a-python/src/a2a/server/request_handlers/rest_handler.py

Line 18 in 89e9b7c

from a2a.grpc import a2a_pb2

Copy link
Author

@vinoo999 vinoo999 Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already encompassed here. a2a.grpc.a2a_pb2 has no grpcio dependencies. Just protobuf. This is encapsulated in the PR already.

Any concerns here?

Copy link
Member

@lkawka lkawka Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a2a_pb2 seems to depend on google-api-core:

a2a-python/src/a2a/grpc/a2a_pb2.py

Line 26 in 89e9b7c

from google.api import client_pb2 as google_dot_api_dot_client__pb2

I think we need to include it here as well.

encryption = ["cryptography>=43.0.0"]
grpc = ["grpcio>=1.60", "grpcio-tools>=1.60", "grpcio_reflection>=1.7.0"]
grpc = ["grpcio>=1.60", "grpcio-tools>=1.60", "grpcio_reflection>=1.7.0", "google-api-core>=1.26.0", "protobuf>=5.29.5"]
telemetry = ["opentelemetry-api>=1.33.0", "opentelemetry-sdk>=1.33.0"]
postgresql = ["sqlalchemy[asyncio,postgresql-asyncpg]>=2.0.0"]
mysql = ["sqlalchemy[asyncio,aiomysql]>=2.0.0"]
Expand Down
8 changes: 7 additions & 1 deletion src/a2a/utils/proto_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@

from typing import Any

from google.protobuf import json_format, struct_pb2

try:
from google.protobuf import json_format, struct_pb2
except ImportError as e:
raise ImportError(
'proto-utils requires protobuf. Install with "pip install a2a-sdk[grpc] or a2a-sdk[http-server] depending on need"'
) from e

from a2a import types
from a2a.grpc import a2a_pb2
Expand Down
Loading