fix: prevent ZK proof replay in ZkAuditVerifier#8
Open
murd3r17 wants to merge 1 commit into
Open
Conversation
Add global _usedProofHashes dedup to block re-submission of the same Groth16 proof across verifyAuditScore and verifyFingerprint. Split the Groth16 internal call helpers for 8- and 3-input verifiers, fix NatSpec, and add MockGroth16Verifier plus regression tests (Fixes ZhangJinHaHaHa#4). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_usedProofHashesmapping to prevent Groth16 proof replay inverifyAuditScoreandverifyFingerprintFixes #4
Test plan
npm run test:zk(4 tests passing)AI assistance
Used Cursor AI to analyze issue #4, implement the fix, and write regression tests.