Pause & restore subscriber#26
Merged
mikelina merged 3 commits intofeature/logTimeSubscriberResponsefrom May 5, 2026
Merged
Conversation
mikelina
changed the base branch from
master
to
feature/logTimeSubscriberResponse
vpasquino
reviewed
Apr 30, 2026
| Route::get('/', 'SubscriberController@getList'); | ||
| Route::post('/', 'SubscriberController@store'); | ||
| Route::get('{id}', 'SubscriberController@getSubscriber')->where('id', '[0-9]+'); | ||
| Route::get('{id}/pause', 'SubscriberController@pauseSubscriber')->where('id', '[0-9]+'); |
Collaborator
There was a problem hiding this comment.
Queste dovrebbero essere delle post, o c'è un motivo per cui sono delle get?
| */ | ||
| public function pauseSubscriber($id) | ||
| { | ||
| $subscriber = $this->subscriberRepository->find($id);; |
| */ | ||
| public function restoreSubscriber($id) | ||
| { | ||
| $subscriber = $this->subscriberRepository->find($id);; |
| ]); | ||
|
|
||
| $pausedKey = Config::get('cache.publisher_paused_key_prefix') . $this->event->channelSubscribe->subscriber_id; | ||
| if (Cache::has($pausedKey)) { |
Collaborator
There was a problem hiding this comment.
Se lo vuoi scrivere più carino e più corto if (Cache::has(config('cache.publisher_paused_key_prefix') . $this->event->channelSubscribe->subscriber_id))
| if (!$subscriber) { | ||
| return response()->error404(__('messages.Subscriber') . $id); | ||
| } | ||
| Cache::put(Config::get('cache.publisher_paused_key_prefix') . $id, true, 3600); |
Collaborator
There was a problem hiding this comment.
Può valere la pena rendere customizzabile il ttl?
LorenzoEmanuele00
approved these changes
May 4, 2026
vpasquino
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create two new APIs:
The code has been modified so that jobs for paused subscribers fail. This ensures that messages intended for the subscriber are persisted to the database and can be resent later without overloading the Elasticache memory.