Joyce collective for mi355 &b200 cluster#1
Open
joyjie818 wants to merge 13 commits intoZ-Y00:mainfrom
Open
Conversation
Adds a patch to fix Megatron FSDP compatibility with PyTorch 2.10+. The patch updates get_mesh_names to use the new DeviceMesh API (_get_root_mesh() and _flatten_mapping) instead of the deprecated _mesh_resources.child_to_root_mapping removed in PyTorch 2.10. The patch is automatically applied when use_megatron_fsdp is enabled. Co-authored-by: WangLingxun <linxwang@amd.com>
Adds support for CPU initialization in Primus Turbo linear layers (RowParallelLinear, ColumnParallelLinear, and LayerNormLinear). When use_cpu_initialization is enabled, the patch disables custom init methods by passing a no-op lambda, allowing Megatron's CPU initialization to work correctly with Primus Turbo's custom layer implementations. Co-authored-by: WangLingxun <linxwang@amd.com>
Previously, the evaluation loss was computed per iteration and overwritten, leading to incorrect averaging when multiple eval iterations are used. This fix accumulates the numerator and denominator separately across all eval iterations and computes the final average at the end.
Co-authored-by: Xiaoming-AMD <Xiaoming.Peng@amd.com>
…odes (AMD-AGI#554) ### Changes: Only flag imbalance if the COUNT of GPUs on each node differs. Example: 4 on Node 0, 4 on Node 1 -> counts=[4,4] -> set={4} -> len=1 -> NOT imbalanced. 7 on Node 0, 1 on Node 1 -> counts=[7,1] -> set={7,1} -> len=2 -> Imbalanced. ### Reason for changes: The previous logic would issue a NUMA imbalance warning if not all GPUs were connected to the same node, resulting in a false positive when using a multi-socket CPU. --------- Co-authored-by: Xiaoming-AMD <Xiaoming.Peng@amd.com>
Created by Joyce for their DCGPU cluster
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Script for 3items
1.node2node submission in MI355 cluster -> submit_pairs.sh(For DCPT cluster)
2.Slurm script for B200 transferred to enroot+srun based for collective ops
3.node2node submission in B200 cluster -> submit_b200.sh(GPUA818/GPUA7DD nodes)