Support MUI v5; removal of "@mui/styles" dependency; TypeScript rewrite;#338
Open
Deckstar wants to merge 25 commits into
Open
Support MUI v5; removal of "@mui/styles" dependency; TypeScript rewrite;#338Deckstar wants to merge 25 commits into
Deckstar wants to merge 25 commits into
Conversation
…up correctly when hovering props;
…removed "@mui/styles" from dependencies;
- made sure "/src/types/index.ts" types were also compiled by removing ".d" from the file name; - made sure "/src/index.ts" included all export items; - made sure JSDoc comments were included in the compilation result; - changed compilation target to use ES6;
… updated documentation;
|
How much time this PR will take to be merged. |
|
Thanks @Deckstar , it works for me 🎉 🚀 ! My app's setup is:
(Btw, please note that the For anyone else, who's like to try @Deckstar's solution: yarn add material-ui-dropzone@https://github.com/Deckstar/material-ui-dropzone |
Add src packages to distribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previous pull requests to update to MUI v5 mostly just changed imports. In this PR I also removed the dependency on "@mui/styles" in favor of the new
styledAPI of MUI v5.At the same time I also rewrote the entire library to be written in TypeScript, and to be compiled with TSC instead of Rollup. This was a very big change, but it seemed to me like unfortunately this library is quite dead? 😅 (I assume so because at the time of writing there haven't been any updates since September 2020, which was over a year ago, and there is a plethora of open issues and pull requests).
I based my fork on this fork by Steven Hazel, which was the v5 update that I previously used in my own project.
Since I assume that this PR won't be merged for a long time (or, more likely, ever), I've published my changes as my own package under "mui-file-dropzone".
Thanks for reading. This library was great and I hope that my changes can be useful for somebody! 😄
Type of change
How Has This Been Tested
Warning!
So far I haven't tested this rewrite at all. Caveat emptor!
Checklist