Fix the outdated product page URL in the MyYoast software statement - #23558
Merged
Conversation
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
Coverage Report for CI Build 0Warning No base build found for commit Coverage: 40.743%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats💛 - Coveralls |
…are statement The `Provided by yoast.com` link on the MyYoast connection screens came from the `client_uri` claim, which pointed at `https://yoast.com/wordpress/plugins/seo/`. That URL now 301s to the premium product page, so the free plugin linked the wrong product. The `logo_uri` claim had the matching problem: it pointed at `premium.svg`, the Premium badge with a crown. Point both at the free plugin's own assets. Both claims are sealed inside MyYoast-signed JWTs, so this edit reaches users only once the credentials are re-signed. The next release build re-signs from these values; `Issuer_Config.php` is deliberately left as trunk baked it for 28.4-RC1. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Rotates the public v0 fallback pair so its sealed `client_uri` and `logo_uri` carry the new values. Signed against production MyYoast via `sign-v0-myyoast-credentials`; `software_version` stays "0", so this pair is unaffected by release version bumps. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
diedexx
force-pushed
the
myyoast-product-url-fix
branch
from
August 18, 2026 13:00
eb20ef7 to
e7652a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The
Provided by yoast.comlink on the MyYoast connection screens pointed athttps://yoast.com/wordpress/plugins/seo/. That URL now 301s to the premium product page, so the free plugin was linking the wrong product.The link text comes from the
client_uriclaim in the OAuth software statement. That claim is sealed inside MyYoast-signed JWTs, so changing the constant in the Grunt task is not enough on its own — both baked credential pairs had to be re-signed against MyYoast before the new URL can reach users.Fixes #23556
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
client_uri+logo_uri), and the re-signed public v0 fallback pair.Issuer_Config.phpis deliberately not touched. Trunk re-baked it for 28.4-RC1 while this PR was open; the next release build re-signs from the claim values in this PR, so baking a pair here would only conflict with that.software_versionis"0"for it — it is version-independent and unaffected by release bumps. It ships on PR/dev/fork builds and would otherwise keep the old branding./product/yoast-seo-wordpress/(free) rather than the premium page, since this statement identifies the free plugin.free_icon.svgis the free counterpart of thepremium.svgit replaces: byte-identical tofree_icon-1.svg(sha256b52541fa…), same viewBox and Yoast mark as the premium badge, without the crown.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
You might need to enable the feature flag if you don't see the integration card:
define("YOAST_SEO_MYYOAST_CONNECTION",true);in wp-config.phpwpseo_myyoast_software_statementfilter.Provided by yoast.comtext next to the Yoast SEO connection.yoast.comlink and check the URL shown in the browser status bar.https://yoast.com/product/yoast-seo-wordpress/. Before this fix it pointed toyoast.com/wordpress/plugins/seo/.Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.[yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached theGoogle Docs Add-onlabel to this PR.Documentation
Quality assurance
grunt build:imagesand committed the results, if my PR introduces or edits images or SVGs.Innovation
innovationlabel.Fixes #23556