refactor: deprecated된 compose-shadow 라이브러리 제거 및 modifier.shadow API 적용 #255
Conversation
…difier api 사용 방식으로 전환
개요더 이상 지원되지 않는 compose-shadow 라이브러리를 제거하고 Jetpack Compose 공식 Shadow API로 마이그레이션합니다. 의존성을 제거하고 MainBottomBar의 그림자 구현을 업데이트하며 Compose BOM을 버전 업그레이드합니다. 변경 사항
예상 코드 리뷰 노력🎯 2 (Simple) | ⏱️ ~15분 시
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@gradle/libs.versions.toml`:
- Line 79: Remove the unused explicit library declaration named
"androidx-foundation" (the entry that sets foundation = "1.10.1") from
libs.versions.toml and keep the BOM-managed "androidx-compose-foundation" entry;
ensure no references to the removed "androidx-foundation" identifier remain in
the codebase and rely on the existing BOM-managed declaration for the
androidx.compose.foundation artifact.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
feature/screens/build.gradle.ktsfeature/screens/src/main/kotlin/com/ninecraft/booket/feature/screens/component/MainBottomBar.ktgradle/libs.versions.toml
💤 Files with no reviewable changes (1)
- feature/screens/build.gradle.kts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: ci-build
- GitHub Check: Compose Stability Check
🔇 Additional comments (2)
gradle/libs.versions.toml (1)
22-22: BOM 버전 확인 완료
dropShadowAPI를 위해 BOM을2025.08.00으로 업데이트한 것이 확인되었습니다. 해당 버전은 Maven 저장소에서 사용 가능하며,dropShadowAPI가 도입된 Compose 1.9.0을 정확히 제공합니다.feature/screens/src/main/kotlin/com/ninecraft/booket/feature/screens/component/MainBottomBar.kt (1)
47-58: Compose FoundationdropShadowAPI로의 마이그레이션이 올바르게 구현되었습니다.
dropShadow모디파이어와Shadow클래스의 사용법이 적절하며, 모든 임포트 문이 올바릅니다. 프로젝트에서 사용 중인 Compose BOM 2025.08.00은dropShadowAPI가 도입된 정확한 버전이므로, API는 안정적으로 지원됩니다.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
| google-service = "4.4.4" | ||
| firebase-bom = "34.7.0" | ||
| firebase-crashlytics = "3.0.6" | ||
| foundation = "1.10.1" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if androidx-foundation is referenced in build files
echo "=== Searching for androidx-foundation usage in build files ==="
find . -type f \( -name "*.gradle" -o -name "*.gradle.kts" -o -name "build.gradle*" \) | head -20
echo ""
echo "=== Searching for androidx-foundation in gradle files ==="
rg "androidx-foundation" --type gradle -n 2>/dev/null || echo "No grep results for androidx-foundation"
echo ""
echo "=== Searching for libs.androidx.foundation usage ==="
rg "libs\.androidx\.foundation" -n 2>/dev/null || echo "No grep results for libs.androidx.foundation"
echo ""
echo "=== Checking the full libs.versions.toml content around lines 98 and 150 ==="
cat -n gradle/libs.versions.toml | sed -n '95,105p;145,155p'Repository: YAPP-Github/Reed-Android
Length of output: 2982
Line 150의 androidx-foundation 선언은 사용되지 않으므로 제거해야 합니다.
androidx.compose.foundation:foundation 아티팩트에 대해 두 개의 라이브러리 선언이 존재합니다:
- Line 98:
androidx-compose-foundation(BOM으로 버전 관리) - Line 150:
androidx-foundation(명시적 버전1.10.1)
코드베이스 전체에서 androidx-foundation이 어디에도 사용되지 않으며, Line 98의 BOM 관리 선언이 실제로 사용되고 있습니다. Line 150의 선언은 제거하세요.
🤖 Prompt for AI Agents
In `@gradle/libs.versions.toml` at line 79, Remove the unused explicit library
declaration named "androidx-foundation" (the entry that sets foundation =
"1.10.1") from libs.versions.toml and keep the BOM-managed
"androidx-compose-foundation" entry; ensure no references to the removed
"androidx-foundation" identifier remain in the codebase and rely on the existing
BOM-managed declaration for the androidx.compose.foundation artifact.
🔗 관련 이슈
📙 작업 설명
🧪 테스트 내역 (선택)
📸 스크린샷 또는 시연 영상 (선택)
💬 추가 설명 or 리뷰 포인트 (선택)
Summary by CodeRabbit
릴리스 노트
의존성 업데이트
리팩토링
✏️ Tip: You can customize this high-level summary in your review settings.