ispstats - Fix assertion (X=rows, Y=columns) #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0cbde62bf Merge pull request #1922 from berry/main_csv_upd 4d6a8a43d add new fir_tdm benchmarks for async update 29d4f6258 Merge pull request #1913 from mlechtan/main 9085cb4ff FIR TDM: Allowing output data of lower precision than input data. 4c4e57f5a DDS: Fix for Metadata generate_graph port definitions 330ac781e create main branch from next branch 8b603566b Merge pull request #1849 from mlechtan/next d16d77b81 Removed unecessary FIR Length calculation for Sym FIR Filters. 55cf30786 Merge pull request #1842 from uvimalku/docs_upd_from_feedback 4f2df13ef Update docs for metadata 47dc60ec2 Update metadata for aie-mlv2 1191be984 Update docs for cfg file 3f6ed0946 Merge pull request #1840 from berry/dev2next_250519 040d24525 add csv datafiles 8667531e2 Merge pull request #1838 from mlechtan/next 367581314 Dev2next 19/05/2025 aee1ef4bd Merge pull request #1836 from mlechtan/next c1e74f5fe Update index.rst 5225c990b Merge pull request #1830 from mlechtan/next a29ff52d9 Docs: Updates following review c3b55bfa2 Merge pull request #1829 from mlechtan/next 6be2c7fb7 Docs: updates following review. 63162fbf5 Merge pull request #1826 from mlechtan/next 7ad658e89 dev2next_16052025 b057504c2 Merge pull request #1822 from berry/dev2next_250515 00358c26f dev to next 118e8f053 Merge pull request #1812 from mlechtan/next 673f83c6c Merge remote-tracking branch 'refs/remotes/origin/next' into next d8f82e9cf Copyright notice update e57196173 Update conf.py 7a0e9000d Copyright notice update. 3c49bfa43 Merge pull request #1807 from berry/dev2next_250508 fa6caa23c dev to next 214776045 Merge pull request #1803 from uvimalku/next_remove_rtl_files b3a3ba77b Debug strip affa6bca7 Merge with next a731046d6 Revert to HLS files for PL FFT 6813b5f38 Merge pull request #1797 from mlechtan/next aca571417 Adding missed out Copyright notices. 6c3189d76 Dev2Next 06052025 786d68613 Merge pull request #1755 from liyuanz/increase_time ff3186aaf Merge pull request #1780 from uvimalku/dev2next_250502 67973542b Remove unintented Makefile changes cccf12fa8 Dev 2 next bcfbd9893 Merge pull request #1770 from berry/dev2next_250429 1e147d5da copy dev to next d83fdd4b4 Merge pull request #1757 from berry/dev2next_250423 ad1c58830 copy dev to next d22391fdc update 018baa426 Merge pull request #1750 from berry/dev2next_250417 94a72fda2 copy dev to next 34c42f1a6 Merge pull request #1741 from mlechtan/next 359b40151 Merge pull request #1740 from mlechtan/next_fir_casc_fix 81247ee95 dev2next 14042025 b00406adf FIRs Meta: Fix for TP_CASC_LEN check 31adc57d4 Merge pull request #1733 from berry/dev2next_250411 44b6a3d5a Merge pull request #1736 from FaaSApps/next_docs_tdm_typo_fix 7189deb61 Update func-fir-TDM.rst 103c88812 copy dev to next 18b5eaa00 Merge pull request #1732 from uvimalku/cr_fixes 02072e771 VSS FFT: Minor fixes 3647a8ec4 Merge pull request #1727 from berry/dev2next_250409 d075c14c6 copy dev to next aded7734f Merge pull request #1722 from berry/dev2next_250402 25104e6a2 copy dev to next 05e808cd1 Merge pull request #1703 from berry/dev2next_250324 611b58e61 Delete graph_euclidean_distance_euclidean_distance.txt 8ee9e7e47 Merge branch 'next' into dev2next_250324 b0c56dc62 copy dev to next 24b5c1766 Merge pull request #1692 from berry/dev2next_250318 20fbd3fdb re rerun dev 2next 6bbc23f34 copy dev to next bc664cb9d Merge pull request #1686 from liyuanz/replace_python 46c71c8a4 Merge branch 'next' into replace_python df1520657 Merge pull request #1683 from berry/dev2next_250313 9039ad9c9 replace python path 29f0997dd copy dev to next 27bd3ce1d Merge pull request #1675 from berry/dev2next_250310 13a1203d0 comment out gen_out_files call 9290f7936 remove compare_out from next 475a2391f copy dev to next 8cbcd7418 Merge pull request #1667 from berry/dev2next_250228 0db2a2b5f copy dev to next 00a03b3c6 Merge pull request #1651 from liyuanz/deprecate_sw_system 6a3093b3f Merge pull request #1656 from berry/dev2next_250219 9018895db change warning eae224921 change warning 600d8bc00 copy dev to next 584dff512 update utils.mk e470d2368 update fa900b4b9 deprecate sw_emu add0597f4 Merge pull request #1638 from berry/dev2next_250206 fade83467 copy dev to next 330590040 Merge pull request #1620 from berry/dev2next_250121 a753a5a22 set default TP_PHASE_RELOAD_API to dds vmc tests d610d8222 copy dev to next 3f0c90fc4 Merge pull request #1569 from liyuanz/add_time_aie d6326e621 Fixing PR template tip example d8fda937e Merge pull request #1591 from berry/dev2next_241128 79218c01b . 58002da54 removing "|& tee ..." from some helper mk files 3f1e9eadc copy dev (02d3292) to next 2788fe542 Merge pull request #1578 from mlechtan/next 84011578f FIR TDM: Add a clause to margin frame calculation b513e1591 Merge pull request #1581 from FaaSApps/jenkinsfile_next f1a4999c4 Update Jenkinsfile fb962aaac FIR TDM: AIE1 optimization for evenFrames architecture bc76f0016 change 2024.2_stable_latest to 2025.1_stable_latest 23321c236 add time for time out cases e4b818acb Merge pull request #1561 from berry/dev2next241108 bbeae76e7 Update getPhaseAlias.py 834ad428f copy dev docs, csv, and other changes to next e237f65be Merge pull request #1559 from mlechtan/next 9d0e9dd0c Revert "Adding benchmark tables max rows" eb2c7b367 Merge pull request #1557 from mlechtan/next 331f07979 Adding benchmark tables max rows a822430b3 Fixing release notes formatting 3f550d5e2 Merge pull request #1555 from mlechtan/next ac45d8c9c dev2next - release notes + docs review items 6b6443014 Merge pull request #1549 from mlechtan/next 1363d0341 Tidy up VMC DFT testcase 5c4402615 Removing docs/src/rst files 954a1a035 Merge branch 'next' of https://gitenterprise.xilinx.com/mlechtan/xf_dsp into next d6739a68e dev2next - copy docs, doxygen + meta license plates da007d345 dev2next - copy docs, doxygen + meta license plates f26b31154 Merge pull request #1537 from berry/next fa199858a Merge branch 'FaaSApps:next' into next 76a2eb377 Merge pull request #1534 from berry/dev2next_241101 c609edb5e Merge branch 'dev2next_241101' of https://gitenterprise.xilinx.com/berry/xf_dsp into dev2next_241101 e077b2844 copy over dds helper mk fix 957b9abf8 Removing Example 2d FFT acb6ccdbf descjson - standardization fix - "625" to 625 b9383a773 copy dev (54fd806) to next 47270f08b Merge pull request #1517 from berry/dev2next_241025 75e2366aa copy dev (5ea67f7) to next 06ee35c96 Merge pull request #1512 from wesleyl/next 118612ba2 Fix errors in DDS LUT stream, Mixer Lut stream and FIR TDM Stream 39d4780cc vmc testcases updated with ssr added in buffer blocks and DDS and Mixer blocks updated 5141ab3c5 Merge pull request #1509 from berry/dev2next_241024 708898e1d copy dev (713b962) to next 358afba29 Merge pull request #1485 from wesleyl/next 8a75273dc Merge pull request #1498 from mlechtan/next e4d5da6b5 Merge branch 'next' into next d8f1e13c2 Adding type_traits to device_defs cfe8998b6 Merge pull request #1486 from berry/dev2next_241017 912de5fa1 add ssr parameters to buffer blocks 90ce09110 fix vmc validator 664b50abf copy L2 examples from dev 142845e24 copy metadata from dev 18b1446ac fix validator wrt VMC 4fc251822 Merge pull request #1478 from berry/dev2next_241015 fef6be597 copy further meta data changes from dev 2c74e3cb8 metadata 5bd75668e L2/include 49007a787 L1/include 1408bf66b L1/src f92783f05 L2/examples 79ea46400 user_guides 154a02ac1 L2/tests 93237744c Merge pull request #1471 from FaaSApps/cr1216301 be272546e Merge pull request #1473 from mlechtan/next a820d1a1a FIR TDM fix for CR-1216299 64225a981 FIR TDM fix for CR-1216299 7896064bf Fix for CR-1216301 10c25af9a Merge pull request #1449 from berry/dev2next_241007 6c23bf8ce conv corr debug strip fix 856bbaee3 copy dev (bc08255) to next 254ab36ba Merge pull request #1431 from wesleyl/next b8ce1d4e7 DDS & Mixer LUT test cases updated f304f18d3 update vmc changes- firlength, capitalize dds-mixer lut, remove dual_ip & out_ports 05660681d Merge branch 'FaaSApps:next' into next cf69e25f5 Merge pull request #1433 from mlechtan/next acb8c95eb Adding missing Meta check for FIR TDM 12968d1f7 Add DDS LUT and Mixer LUT blocks and update vmc_dsp.py file 4c16b1de1 Merge pull request #1424 from berry/dev2next_240925 794f88ede part 3b 95a64e38e dev to next - part 3 to fix VMC fails 2b16d4f14 dev to next - part 2 1fd7dcea8 copy dev 2 next - part 1 8a20c03cf Merge pull request #1409 from berry/dev2next_240923 f7637abd7 Merge pull request #1363 from wesleyl/next 009c9f1f5 CR1210012 fix for fft_1024_tmp1 allocation 88b18a3ef copy dev to next 4be538fe5 Merge branch 'FaaSApps:next' into next 3df41977e Delete decomposer_multi_params.json ba6f48794 Merge branch 'FaaSApps:next' into next 38a4e388d Merge pull request #1405 from uvimalku/dds_cr_next 19f8d9340 DDS MIxer metadata bug fix 51b75e776 DDS LUT update 5c77f7841 push VMC changes 1eefba75b Merge pull request #1391 from berry/dev2next_240912 8ce03229d fix buggy debug strip ea7c53e47 ew d48c7b03d debug strip missing files. and copyright fix dee880c03 copy dev (fc696f3) to next b9b4493f1 Merge pull request #1387 from liyuanz/revert-1322-add_config 0db7e88ee Revert "Add template of config file for system case " 1c9d8ebf7 Merge pull request #1375 from berry/dev2next_240904 071dbbb89 copy dev (commit e43b507) to next 379d39543 Merge pull request #1359 from berry/dev2next240826 3bcc9cde0 FIR TDM VMC Meta fix 60fb497af FIR TDM VMC Meta fix 85afa01a2 copy from dev commit 77d16e6 094fde662 Merge pull request #1322 from liyuanz/add_config 82804e8d5 Merge pull request #1349 from wesleyl/next d4fd62409 function definition updated for tdm da8a9ba4a Merge pull request #1345 from berry/dev2next_240815 99b7cc544 fix formatting of vss files dcffa3639 dev 987f25e to next aa0203cf3 Update Jenkinsfile a7be41d2d update 77a03ac2d add config file 2e7d3f4b0 Merge pull request #1316 from berry/dev2next_240730 952a0ffd5 dev commit a4d561c to next branch 5f886f4d3 Merge pull request #1306 from berry/dev2next_24_07_23 795c1ccc2 copy dev (commit c75f418) to next cc6e31f44 Merge pull request #1291 from berry/dev2next_240701 3065c5c3f FIR TDM fix for evenFrames optimization switch. #1293 ca46bd59f dev commit 5b25784 to next 3c7fa604f Merge pull request #1262 from liyuanz/fix_os_next 0714ba636 copy contents of dev to next (dev commit 2b4b9c9) (#1288) 99fb748b8 Revert next branch back to 2024.1_stable_latest (#1279) d2228a4d1 change 2024.1_stable_latest to 2024.2_stable_latest 13b76bb4f update to next branch Co-authored-by: sdausr <[email protected]>
0e3a27c40 Merge pull request #1955 from uvimalku/main fe0eaf6f8 Update dds_mixer_lut.py 0a0a48dea Update dds_mixer.py 0cbde62bf Merge pull request #1922 from berry/main_csv_upd 4d6a8a43d add new fir_tdm benchmarks for async update 29d4f6258 Merge pull request #1913 from mlechtan/main 9085cb4ff FIR TDM: Allowing output data of lower precision than input data. 4c4e57f5a DDS: Fix for Metadata generate_graph port definitions 330ac781e create main branch from next branch 8b603566b Merge pull request #1849 from mlechtan/next d16d77b81 Removed unecessary FIR Length calculation for Sym FIR Filters. 55cf30786 Merge pull request #1842 from uvimalku/docs_upd_from_feedback 4f2df13ef Update docs for metadata 47dc60ec2 Update metadata for aie-mlv2 1191be984 Update docs for cfg file 3f6ed0946 Merge pull request #1840 from berry/dev2next_250519 040d24525 add csv datafiles 8667531e2 Merge pull request #1838 from mlechtan/next 367581314 Dev2next 19/05/2025 aee1ef4bd Merge pull request #1836 from mlechtan/next c1e74f5fe Update index.rst 5225c990b Merge pull request #1830 from mlechtan/next a29ff52d9 Docs: Updates following review c3b55bfa2 Merge pull request #1829 from mlechtan/next 6be2c7fb7 Docs: updates following review. 63162fbf5 Merge pull request #1826 from mlechtan/next 7ad658e89 dev2next_16052025 b057504c2 Merge pull request #1822 from berry/dev2next_250515 00358c26f dev to next 118e8f053 Merge pull request #1812 from mlechtan/next 673f83c6c Merge remote-tracking branch 'refs/remotes/origin/next' into next d8f82e9cf Copyright notice update e57196173 Update conf.py 7a0e9000d Copyright notice update. 3c49bfa43 Merge pull request #1807 from berry/dev2next_250508 fa6caa23c dev to next 214776045 Merge pull request #1803 from uvimalku/next_remove_rtl_files b3a3ba77b Debug strip affa6bca7 Merge with next a731046d6 Revert to HLS files for PL FFT 6813b5f38 Merge pull request #1797 from mlechtan/next aca571417 Adding missed out Copyright notices. 6c3189d76 Dev2Next 06052025 786d68613 Merge pull request #1755 from liyuanz/increase_time ff3186aaf Merge pull request #1780 from uvimalku/dev2next_250502 67973542b Remove unintented Makefile changes cccf12fa8 Dev 2 next bcfbd9893 Merge pull request #1770 from berry/dev2next_250429 1e147d5da copy dev to next d83fdd4b4 Merge pull request #1757 from berry/dev2next_250423 ad1c58830 copy dev to next d22391fdc update 018baa426 Merge pull request #1750 from berry/dev2next_250417 94a72fda2 copy dev to next 34c42f1a6 Merge pull request #1741 from mlechtan/next 359b40151 Merge pull request #1740 from mlechtan/next_fir_casc_fix 81247ee95 dev2next 14042025 b00406adf FIRs Meta: Fix for TP_CASC_LEN check 31adc57d4 Merge pull request #1733 from berry/dev2next_250411 44b6a3d5a Merge pull request #1736 from FaaSApps/next_docs_tdm_typo_fix 7189deb61 Update func-fir-TDM.rst 103c88812 copy dev to next 18b5eaa00 Merge pull request #1732 from uvimalku/cr_fixes 02072e771 VSS FFT: Minor fixes 3647a8ec4 Merge pull request #1727 from berry/dev2next_250409 d075c14c6 copy dev to next aded7734f Merge pull request #1722 from berry/dev2next_250402 25104e6a2 copy dev to next 05e808cd1 Merge pull request #1703 from berry/dev2next_250324 611b58e61 Delete graph_euclidean_distance_euclidean_distance.txt 8ee9e7e47 Merge branch 'next' into dev2next_250324 b0c56dc62 copy dev to next 24b5c1766 Merge pull request #1692 from berry/dev2next_250318 20fbd3fdb re rerun dev 2next 6bbc23f34 copy dev to next bc664cb9d Merge pull request #1686 from liyuanz/replace_python 46c71c8a4 Merge branch 'next' into replace_python df1520657 Merge pull request #1683 from berry/dev2next_250313 9039ad9c9 replace python path 29f0997dd copy dev to next 27bd3ce1d Merge pull request #1675 from berry/dev2next_250310 13a1203d0 comment out gen_out_files call 9290f7936 remove compare_out from next 475a2391f copy dev to next 8cbcd7418 Merge pull request #1667 from berry/dev2next_250228 0db2a2b5f copy dev to next 00a03b3c6 Merge pull request #1651 from liyuanz/deprecate_sw_system 6a3093b3f Merge pull request #1656 from berry/dev2next_250219 9018895db change warning eae224921 change warning 600d8bc00 copy dev to next 584dff512 update utils.mk e470d2368 update fa900b4b9 deprecate sw_emu add0597f4 Merge pull request #1638 from berry/dev2next_250206 fade83467 copy dev to next 330590040 Merge pull request #1620 from berry/dev2next_250121 a753a5a22 set default TP_PHASE_RELOAD_API to dds vmc tests d610d8222 copy dev to next 3f0c90fc4 Merge pull request #1569 from liyuanz/add_time_aie d6326e621 Fixing PR template tip example d8fda937e Merge pull request #1591 from berry/dev2next_241128 79218c01b . 58002da54 removing "|& tee ..." from some helper mk files 3f1e9eadc copy dev (02d3292) to next 2788fe542 Merge pull request #1578 from mlechtan/next 84011578f FIR TDM: Add a clause to margin frame calculation b513e1591 Merge pull request #1581 from FaaSApps/jenkinsfile_next f1a4999c4 Update Jenkinsfile fb962aaac FIR TDM: AIE1 optimization for evenFrames architecture bc76f0016 change 2024.2_stable_latest to 2025.1_stable_latest 23321c236 add time for time out cases e4b818acb Merge pull request #1561 from berry/dev2next241108 bbeae76e7 Update getPhaseAlias.py 834ad428f copy dev docs, csv, and other changes to next e237f65be Merge pull request #1559 from mlechtan/next 9d0e9dd0c Revert "Adding benchmark tables max rows" eb2c7b367 Merge pull request #1557 from mlechtan/next 331f07979 Adding benchmark tables max rows a822430b3 Fixing release notes formatting 3f550d5e2 Merge pull request #1555 from mlechtan/next ac45d8c9c dev2next - release notes + docs review items 6b6443014 Merge pull request #1549 from mlechtan/next 1363d0341 Tidy up VMC DFT testcase 5c4402615 Removing docs/src/rst files 954a1a035 Merge branch 'next' of https://gitenterprise.xilinx.com/mlechtan/xf_dsp into next d6739a68e dev2next - copy docs, doxygen + meta license plates da007d345 dev2next - copy docs, doxygen + meta license plates f26b31154 Merge pull request #1537 from berry/next fa199858a Merge branch 'FaaSApps:next' into next 76a2eb377 Merge pull request #1534 from berry/dev2next_241101 c609edb5e Merge branch 'dev2next_241101' of https://gitenterprise.xilinx.com/berry/xf_dsp into dev2next_241101 e077b2844 copy over dds helper mk fix 957b9abf8 Removing Example 2d FFT acb6ccdbf descjson - standardization fix - "625" to 625 b9383a773 copy dev (54fd806) to next 47270f08b Merge pull request #1517 from berry/dev2next_241025 75e2366aa copy dev (5ea67f7) to next 06ee35c96 Merge pull request #1512 from wesleyl/next 118612ba2 Fix errors in DDS LUT stream, Mixer Lut stream and FIR TDM Stream 39d4780cc vmc testcases updated with ssr added in buffer blocks and DDS and Mixer blocks updated 5141ab3c5 Merge pull request #1509 from berry/dev2next_241024 708898e1d copy dev (713b962) to next 358afba29 Merge pull request #1485 from wesleyl/next 8a75273dc Merge pull request #1498 from mlechtan/next e4d5da6b5 Merge branch 'next' into next d8f1e13c2 Adding type_traits to device_defs cfe8998b6 Merge pull request #1486 from berry/dev2next_241017 912de5fa1 add ssr parameters to buffer blocks 90ce09110 fix vmc validator 664b50abf copy L2 examples from dev 142845e24 copy metadata from dev 18b1446ac fix validator wrt VMC 4fc251822 Merge pull request #1478 from berry/dev2next_241015 fef6be597 copy further meta data changes from dev 2c74e3cb8 metadata 5bd75668e L2/include 49007a787 L1/include 1408bf66b L1/src f92783f05 L2/examples 79ea46400 user_guides 154a02ac1 L2/tests 93237744c Merge pull request #1471 from FaaSApps/cr1216301 be272546e Merge pull request #1473 from mlechtan/next a820d1a1a FIR TDM fix for CR-1216299 64225a981 FIR TDM fix for CR-1216299 7896064bf Fix for CR-1216301 10c25af9a Merge pull request #1449 from berry/dev2next_241007 6c23bf8ce conv corr debug strip fix 856bbaee3 copy dev (bc08255) to next 254ab36ba Merge pull request #1431 from wesleyl/next b8ce1d4e7 DDS & Mixer LUT test cases updated f304f18d3 update vmc changes- firlength, capitalize dds-mixer lut, remove dual_ip & out_ports 05660681d Merge branch 'FaaSApps:next' into next cf69e25f5 Merge pull request #1433 from mlechtan/next acb8c95eb Adding missing Meta check for FIR TDM 12968d1f7 Add DDS LUT and Mixer LUT blocks and update vmc_dsp.py file 4c16b1de1 Merge pull request #1424 from berry/dev2next_240925 794f88ede part 3b 95a64e38e dev to next - part 3 to fix VMC fails 2b16d4f14 dev to next - part 2 1fd7dcea8 copy dev 2 next - part 1 8a20c03cf Merge pull request #1409 from berry/dev2next_240923 f7637abd7 Merge pull request #1363 from wesleyl/next 009c9f1f5 CR1210012 fix for fft_1024_tmp1 allocation 88b18a3ef copy dev to next 4be538fe5 Merge branch 'FaaSApps:next' into next 3df41977e Delete decomposer_multi_params.json ba6f48794 Merge branch 'FaaSApps:next' into next 38a4e388d Merge pull request #1405 from uvimalku/dds_cr_next 19f8d9340 DDS MIxer metadata bug fix 51b75e776 DDS LUT update 5c77f7841 push VMC changes 1eefba75b Merge pull request #1391 from berry/dev2next_240912 8ce03229d fix buggy debug strip ea7c53e47 ew d48c7b03d debug strip missing files. and copyright fix dee880c03 copy dev (fc696f3) to next b9b4493f1 Merge pull request #1387 from liyuanz/revert-1322-add_config 0db7e88ee Revert "Add template of config file for system case " 1c9d8ebf7 Merge pull request #1375 from berry/dev2next_240904 071dbbb89 copy dev (commit e43b507) to next 379d39543 Merge pull request #1359 from berry/dev2next240826 3bcc9cde0 FIR TDM VMC Meta fix 60fb497af FIR TDM VMC Meta fix 85afa01a2 copy from dev commit 77d16e6 094fde662 Merge pull request #1322 from liyuanz/add_config 82804e8d5 Merge pull request #1349 from wesleyl/next d4fd62409 function definition updated for tdm da8a9ba4a Merge pull request #1345 from berry/dev2next_240815 99b7cc544 fix formatting of vss files dcffa3639 dev 987f25e to next aa0203cf3 Update Jenkinsfile a7be41d2d update 77a03ac2d add config file 2e7d3f4b0 Merge pull request #1316 from berry/dev2next_240730 952a0ffd5 dev commit a4d561c to next branch 5f886f4d3 Merge pull request #1306 from berry/dev2next_24_07_23 795c1ccc2 copy dev (commit c75f418) to next cc6e31f44 Merge pull request #1291 from berry/dev2next_240701 3065c5c3f FIR TDM fix for evenFrames optimization switch. #1293 ca46bd59f dev commit 5b25784 to next 3c7fa604f Merge pull request #1262 from liyuanz/fix_os_next 0714ba636 copy contents of dev to next (dev commit 2b4b9c9) (#1288) 99fb748b8 Revert next branch back to 2024.1_stable_latest (#1279) d2228a4d1 change 2024.1_stable_latest to 2024.2_stable_latest 13b76bb4f update to next branch Co-authored-by: sdausr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assertion does not match because it checks checks X against columns and Y against rows. But the code treats X as rows and Y as columns.
I generally would suggest to rename "x" and "y" to "rows" and "cloumns". X/Y can too easily be misunderstood.